Changing to use readonlyspan

Author: uabarahona

src/Antiforgery/test/DefaultAntiforgeryTokenStoreTest.cs

@@ -491,7 +491,7 @@ public void Append(string key, string value)
                 throw new NotImplementedException();
             }
 
-            public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
+            public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
             {
                 throw new NotImplementedException();
             }

src/Http/Http.Features/src/IResponseCookies.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
 using System.Collections.Generic;
 
 namespace Microsoft.AspNetCore.Http
@@ -30,7 +31,7 @@ public interface IResponseCookies
         /// </summary>
         /// <param name="keyValuePairs">Key value pair collections whose elements will be added as cookies.</param>
         /// <param name="options"><see cref="CookieOptions"/> included in new cookie settings.</param>
-        void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options);
+        void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options);
 
         /// <summary>
         /// Sets an expired cookie.

src/Http/Http.Features/src/PublicAPI.Unshipped.txt

@@ -15,4 +15,4 @@ Microsoft.AspNetCore.Http.Features.IFeatureCollection.Set<TFeature>(TFeature? in
 Microsoft.AspNetCore.Http.Features.IServerVariablesFeature.this[string! variableName].get -> string?
 Microsoft.AspNetCore.Http.ISession.TryGetValue(string! key, out byte[]? value) -> bool
 Microsoft.AspNetCore.Http.Features.FeatureCollection.FeatureCollection(int initialCapacity) -> void
-Microsoft.AspNetCore.Http.IResponseCookies.Append(System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string!, string!>>! keyValuePairs, Microsoft.AspNetCore.Http.CookieOptions! options) -> void
+Microsoft.AspNetCore.Http.IResponseCookies.Append(System.ReadOnlySpan<System.Collections.Generic.KeyValuePair<string!, string!>> keyValuePairs, Microsoft.AspNetCore.Http.CookieOptions! options) -> void

src/Http/Http/src/Internal/ResponseCookies.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Microsoft.AspNetCore.Http.Features;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
@@ -90,7 +89,7 @@ public void Append(string key, string value, CookieOptions options)
         }
 
         /// <inheritdoc />
-        public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
+        public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
         {
             if (options == null)
             {
@@ -127,7 +126,7 @@ public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, Cook
             };
 
             var cookierHeaderValue = setCookieHeaderValue.ToString()[1..];
-            var cookies = new string[keyValuePairs.Count()];
+            var cookies = new string[keyValuePairs.Length];
             var position = 0;
 
             foreach (var keyValuePair in keyValuePairs)

src/Mvc/Mvc.ViewFeatures/test/CookieTempDataProviderTest.cs

@@ -417,7 +417,7 @@ IEnumerator IEnumerable.GetEnumerator()
                 return GetEnumerator();
             }
 
-            public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
+            public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
             {
                 foreach (var keyValuePair in keyValuePairs)
                 {

src/Security/CookiePolicy/src/ResponseCookiesWrapper.cs

@@ -153,14 +153,14 @@ public void Append(string key, string value, CookieOptions options)
             }
         }
 
-        public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
+        public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
         {
             if (options == null)
             {
                 throw new ArgumentNullException(nameof(options));
             }
 
-            var nonSuppressedValues = new Dictionary<string, string>();
+            var nonSuppressedValues = new List<KeyValuePair<string, string>>();
 
             foreach (var keyValuePair in keyValuePairs)
             {
@@ -169,15 +169,15 @@ public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, Cook
 
                 if (ApplyAppendPolicy(ref key, ref value, options))
                 {
-                    nonSuppressedValues.Add(key, value);
+                    nonSuppressedValues.Add(KeyValuePair.Create(key, value));
                 }
                 else
                 {
                     _logger.CookieSuppressed(keyValuePair.Key);
                 }
             }
 
-            Cookies.Append(nonSuppressedValues, options);
+            Cookies.Append(nonSuppressedValues.ToArray(), options);
         }
 
         private bool ApplyAppendPolicy(ref string key, ref string value, CookieOptions options)

src/Security/CookiePolicy/test/CookiePolicyTests.cs

@@ -486,7 +486,7 @@ public void Append(string key, string value, CookieOptions options)
                     throw new NotImplementedException();
                 }
 
-                public void Append(IEnumerable<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
+                public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
                 {
                     throw new NotImplementedException();
                 }

src/Shared/ChunkingCookieManager/ChunkingCookieManager.cs

@@ -208,19 +208,17 @@ public void AppendResponseCookie(HttpContext context, string key, string? value,
                 var dataSizePerCookie = ChunkSize.Value - templateLength - 3; // Budget 3 chars for the chunkid.
                 var cookieChunkCount = (int)Math.Ceiling(value.Length * 1.0 / dataSizePerCookie);
 
-                List<KeyValuePair<string, string>> keyValuePairs = new(cookieChunkCount)
-                {
-                    KeyValuePair.Create(key, ChunkCountPrefix + cookieChunkCount.ToString(CultureInfo.InvariantCulture))
-                };
-
+                var keyValuePairs = new KeyValuePair<string, string>[cookieChunkCount + 1];
+                keyValuePairs[0] = KeyValuePair.Create(key, ChunkCountPrefix + cookieChunkCount.ToString(CultureInfo.InvariantCulture));
+                
                 var offset = 0;
                 for (var chunkId = 1; chunkId <= cookieChunkCount; chunkId++)
                 {
                     var remainingLength = value.Length - offset;
                     var length = Math.Min(dataSizePerCookie, remainingLength);
                     var segment = value.Substring(offset, length);
                     offset += length;
-                    keyValuePairs.Add(KeyValuePair.Create(string.Concat(key, ChunkKeySuffix, chunkId.ToString(CultureInfo.InvariantCulture)), segment));
+                    keyValuePairs[chunkId] = KeyValuePair.Create(string.Concat(key, ChunkKeySuffix, chunkId.ToString(CultureInfo.InvariantCulture)), segment);
                 }
 
                 responseCookies.Append(keyValuePairs, options);    
@@ -306,14 +304,12 @@ public void DeleteCookie(HttpContext context, string key, CookieOptions options)
 
             var responseCookies = context.Response.Cookies;
 
-            List<KeyValuePair<string, string>> keyValuePairs = new(chunks)
-            {
-                KeyValuePair.Create(key, string.Empty)
-            };
-
+            var keyValuePairs = new KeyValuePair<string, string>[chunks + 1];
+            keyValuePairs[0] = KeyValuePair.Create(key, string.Empty);
+            
             for (var i = 1; i <= chunks; i++)
             {
-                keyValuePairs.Add(KeyValuePair.Create(string.Concat(key, "C", i.ToString(CultureInfo.InvariantCulture)), string.Empty));
+                keyValuePairs[i] = KeyValuePair.Create(string.Concat(key, "C", i.ToString(CultureInfo.InvariantCulture)), string.Empty);
             }
 
             responseCookies.Append(keyValuePairs, new CookieOptions()