Stephen's suggestion to convert the IEnumerator to an array and implicitly convert to StringValues rather than via the cast

Daniel-Genkin-MS-2 · Daniel-Genkin-MS-2 · commit 28e767da3792 · 2022-05-12T10:55:05.000-07:00
diff --git a/src/Servers/Kestrel/perf/Microbenchmarks/Http2/Http2ConnectionBenchmarkBase.cs b/src/Servers/Kestrel/perf/Microbenchmarks/Http2/Http2ConnectionBenchmarkBase.cs
@@ -58,7 +58,7 @@ public virtual void GlobalSetup()
             var cookies = new StringValues("0=1");
             for (var index = 1; index < NumCookies; index++)
             {
-                cookies = (StringValues)cookies.Append($"{index}={index + 1}");
+                cookies = cookies.Append($"{index}={index + 1}").ToArray();
             }
             _httpRequestHeaders[HeaderNames.Cookie] = cookies;
         }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public virtual void GlobalSetup()`
`58`	`58`	`var cookies = new StringValues("0=1");`
`59`	`59`	`for (var index = 1; index < NumCookies; index++)`
`60`	`60`	`{`
`61`		`- cookies = (StringValues)cookies.Append($"{index}={index + 1}");`
	`61`	`+ cookies = cookies.Append($"{index}={index + 1}").ToArray();`
`62`	`62`	`}`
`63`	`63`	`_httpRequestHeaders[HeaderNames.Cookie] = cookies;`
`64`	`64`	`}`