Skip to content

Commit 2434047

Browse files
authored
Quarantined tests which were not running (skipped on Helix) (#23023)
1 parent 580a6cc commit 2434047

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

src/Components/WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Components.WebAssembly.Build
1515
public class RuntimeDependenciesResolverTest
1616
{
1717
[Fact]
18-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10426")]
18+
[QuarantinedTest]
1919
public void FindsReferenceAssemblyGraph_ForStandaloneApp()
2020
{
2121
// Arrange

src/Hosting/Hosting/test/WebHostTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ public async Task WebHostShutsDownWhenTokenTriggers()
198198
}
199199

200200
[ConditionalFact]
201-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7291")]
201+
[QuarantinedTest]
202202
public async Task WebHostStopAsyncUsesDefaultTimeoutIfGivenTokenDoesNotFire()
203203
{
204204
var data = new Dictionary<string, string>
@@ -313,7 +313,7 @@ public async Task WebHostStopAsyncCanBeCancelledEarly()
313313
}
314314

315315
[ConditionalFact]
316-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7291")]
316+
[QuarantinedTest]
317317
public void WebHostApplicationLifetimeEventsOrderedCorrectlyDuringShutdown()
318318
{
319319
using (var host = CreateBuilder()

src/ProjectTemplates/test/ByteOrderMarkTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public ByteOrderMarkTest(ITestOutputHelper output)
2222
}
2323

2424
[ConditionalTheory]
25-
[SkipOnHelix("missing files")]
25+
[QuarantinedTest]
2626
[InlineData("Web.ProjectTemplates")]
2727
[InlineData("Web.Spa.ProjectTemplates")]
2828
public void JSAndJSONInAllTemplates_ShouldNotContainBOM(string projectName)
@@ -64,7 +64,7 @@ public void JSAndJSONInAllTemplates_ShouldNotContainBOM(string projectName)
6464
}
6565

6666
[ConditionalFact]
67-
[SkipOnHelix("missing files")]
67+
[QuarantinedTest]
6868
public void RazorFilesInWebProjects_ShouldContainBOM()
6969
{
7070
var projectName = "Web.ProjectTemplates";

src/Servers/HttpSys/test/FunctionalTests/Listener/ServerTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public async Task Server_SetRejectionVerbosityLevel_Success()
126126
}
127127

128128
[ConditionalFact]
129-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/pull/20718#issuecomment-618758634")]
129+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/pull/20718#issuecomment-618758634")]
130130
public void Server_RegisterUnavailablePrefix_ThrowsActionableHttpSysException()
131131
{
132132
var options = new HttpSysOptions();

src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public async Task StartsWithDotnetOnThePath(string path)
119119
[SkipIfNotAdmin]
120120
[RequiresNewShim]
121121
[RequiresIIS(IISCapability.PoolEnvironmentVariables)]
122-
[SkipOnHelix("https://github.com/dotnet/aspnetcore-internal/issues/2221")]
122+
[QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2221")]
123123
public async Task StartsWithDotnetInstallLocation(RuntimeArchitecture runtimeArchitecture)
124124
{
125125
var deploymentParameters = Fixture.GetBaseDeploymentParameters();

src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class AddressRegistrationTests : TestApplicationErrorLoggerLoggedTest
3232

3333
[ConditionalFact]
3434
[HostNameIsReachable]
35-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7267")]
35+
[QuarantinedTest]
3636
public async Task RegisterAddresses_HostName_Success()
3737
{
3838
var hostName = Dns.GetHostName();
@@ -344,7 +344,7 @@ public async Task ListenAnyIP_IPv6_Success()
344344

345345
[ConditionalFact]
346346
[HostNameIsReachable]
347-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7267")]
347+
[QuarantinedTest]
348348
public async Task ListenAnyIP_HostName_Success()
349349
{
350350
var hostName = Dns.GetHostName();

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class TlsTests : LoggedTest
2929
private static X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate();
3030

3131
[ConditionalFact]
32-
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7000")]
32+
[QuarantinedTest]
3333
public async Task TlsHandshakeRejectsTlsLessThan12()
3434
{
3535
using (var server = new TestServer(context =>

0 commit comments

Comments
 (0)