Skip to content

Commit 1a4dbb7

Browse files
Contributing: fixed some typos (#18494)
* Contributing: fixed some typos * Spotted another typo * this will cause a breaking change * made DefaultDisconetTimout readonly * made ConnectionOptionsSetup class internal * Revert "made ConnectionOptionsSetup class internal" This reverts commit 90f94d2. * Update HttpConnectionDispatcher.Log.cs * Apply suggestions from code review Co-authored-by: Brennan <[email protected]>
1 parent d8b6823 commit 1a4dbb7

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

src/Middleware/HealthChecks/src/Builder/HealthCheckApplicationBuilderExtensions.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ public static IApplicationBuilder UseHealthChecks(this IApplicationBuilder app,
8585
/// <para>
8686
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
8787
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
88-
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
89-
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
88+
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
89+
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
9090
/// character.
9191
/// </para>
9292
/// <para>
@@ -115,8 +115,8 @@ public static IApplicationBuilder UseHealthChecks(this IApplicationBuilder app,
115115
/// <para>
116116
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
117117
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
118-
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
119-
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
118+
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
119+
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
120120
/// character.
121121
/// </para>
122122
/// <para>
@@ -156,8 +156,8 @@ public static IApplicationBuilder UseHealthChecks(this IApplicationBuilder app,
156156
/// <para>
157157
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
158158
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
159-
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
160-
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
159+
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
160+
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
161161
/// character.
162162
/// </para>
163163
/// </remarks>
@@ -189,8 +189,8 @@ public static IApplicationBuilder UseHealthChecks(this IApplicationBuilder app,
189189
/// <para>
190190
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
191191
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
192-
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
193-
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
192+
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
193+
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
194194
/// character.
195195
/// </para>
196196
/// </remarks>
@@ -237,7 +237,7 @@ private static void UseHealthChecksCore(IApplicationBuilder app, PathString path
237237

238238
// NOTE: we explicitly don't use Map here because it's really common for multiple health
239239
// check middleware to overlap in paths. Ex: `/health`, `/health/detailed` - this is order
240-
// sensititive with Map, and it's really surprising to people.
240+
// sensitive with Map, and it's really surprising to people.
241241
//
242242
// See:
243243
// https://github.com/aspnet/Diagnostics/issues/511
@@ -254,7 +254,7 @@ private static void UseHealthChecksCore(IApplicationBuilder app, PathString path
254254
// We allow you to listen on all URLs by providing the empty PathString.
255255
(!path.HasValue ||
256256

257-
// If you do provide a PathString, want to handle all of the special cases that
257+
// If you do provide a PathString, want to handle all of the special cases that
258258
// StartsWithSegments handles, but we also want it to have exact match semantics.
259259
//
260260
// Ex: /Foo/ == /Foo (true)

src/Middleware/HttpOverrides/src/CertificateForwardingBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace Microsoft.AspNetCore.Builder
88
{
99
/// <summary>
10-
/// Extension methods for using certificate fowarding.
10+
/// Extension methods for using certificate forwarding.
1111
/// </summary>
1212
public static class CertificateForwardingBuilderExtensions
1313
{

src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.Log.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public static void ReceivedDeleteRequestForUnsupportedTransport(ILogger logger,
113113
_receivedDeleteRequestForUnsupportedTransport(logger, transportType, null);
114114
}
115115

116-
public static void TerminatingConection(ILogger logger)
116+
public static void TerminatingConnection(ILogger logger)
117117
{
118118
_terminatingConnection(logger, null);
119119
}

src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ private async Task ProcessDeleteAsync(HttpContext context)
489489
return;
490490
}
491491

492-
Log.TerminatingConection(_logger);
492+
Log.TerminatingConnection(_logger);
493493

494494
// Dispose the connection, but don't wait for it. We assign it here so we can wait in tests
495495
connection.DisposeAndRemoveTask = _manager.DisposeAndRemoveAsync(connection, closeGracefully: false);

0 commit comments

Comments
 (0)