SkipValidation -> IsTestMock

Author: halter73

src/Servers/Kestrel/Core/src/Internal/Certificates/CertificateConfigLoader.cs

@@ -23,7 +23,7 @@ public CertificateConfigLoader(IHostEnvironment hostEnvironment, ILogger<Kestrel
         public IHostEnvironment HostEnvironment { get; }
         public ILogger<KestrelServer> Logger { get; }
 
-        public bool SkipValidation => false;
+        public bool IsTestMock => false;
 
         public X509Certificate2 LoadCertificate(CertificateConfig certInfo, string endpointName)
         {

src/Servers/Kestrel/Core/src/Internal/Certificates/ICertificateConfigLoader.cs

@@ -7,8 +7,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Certificates
 {
     internal interface ICertificateConfigLoader
     {
-        // SkipValidation is only true in tests.
-        bool SkipValidation { get; }
+        bool IsTestMock { get; }
 
         X509Certificate2 LoadCertificate(CertificateConfig certInfo, string endpointName);
     }

src/Servers/Kestrel/Core/src/Internal/SniOptionsSelector.cs

@@ -68,8 +68,7 @@ public SniOptionsSelector(
                     }
                 }
 
-                // SkipValidation is only true in tests.
-                if (!certifcateConfigLoader.SkipValidation && sslOptions.ServerCertificate is X509Certificate2 cert2)
+                if (!certifcateConfigLoader.IsTestMock && sslOptions.ServerCertificate is X509Certificate2 cert2)
                 {
                     HttpsConnectionMiddleware.EnsureCertificateIsAllowedForServerAuth(cert2);
                 }

src/Servers/Kestrel/Core/test/SniOptionsSelectorTests.cs

@@ -743,7 +743,7 @@ private class MockCertificateConfigLoader : ICertificateConfigLoader
         {
             public Dictionary<object, string> CertToPathDictionary { get; } = new Dictionary<object, string>(ReferenceEqualityComparer.Instance);
 
-            public bool SkipValidation => true;
+            public bool IsTestMock => true;
 
             public X509Certificate2 LoadCertificate(CertificateConfig certInfo, string endpointName)
             {