Address nullability feedback

Fixes #25275

Author: pranavkm

src/Components/Server/src/Circuits/CircuitIdFactory.cs

@@ -48,7 +48,7 @@ public CircuitId CreateCircuitId()
             return new CircuitId(Base64UrlTextEncoder.Encode(secret), Base64UrlTextEncoder.Encode(id));
         }
 
-        public bool TryParseCircuitId(string text, out CircuitId circuitId)
+        public bool TryParseCircuitId(string? text, out CircuitId circuitId)
         {
             if (text is null)
             {

src/Components/Server/src/Circuits/RemoteRenderer.cs

@@ -27,7 +27,7 @@ internal class RemoteRenderer : Microsoft.AspNetCore.Components.RenderTree.Rende
         /// <summary>
         /// Notifies when a rendering exception occurred.
         /// </summary>
-        public event EventHandler<Exception> UnhandledException;
+        public event EventHandler<Exception>? UnhandledException;
 
         /// <summary>
         /// Creates a new <see cref="RemoteRenderer"/>.
@@ -171,7 +171,7 @@ protected override Task UpdateDisplayAsync(in Microsoft.AspNetCore.Components.Re
                 pendingRender = new UnacknowledgedRenderBatch(
                     renderId,
                     arrayBuilder,
-                    new TaskCompletionSource<object>(),
+                    new TaskCompletionSource(),
                     ValueStopwatch.StartNew());
 
                 // Buffer the rendered batches no matter what. We'll send it down immediately when the client
@@ -234,7 +234,7 @@ private async Task WriteBatchBytesAsync(UnacknowledgedRenderBatch pending)
             // disposed.
         }
 
-        public Task OnRenderCompletedAsync(long incomingBatchId, string errorMessageOrNull)
+        public Task OnRenderCompletedAsync(long incomingBatchId, string? errorMessageOrNull)
         {
             if (_disposing)
             {
@@ -308,7 +308,7 @@ public Task OnRenderCompletedAsync(long incomingBatchId, string errorMessageOrNu
             }
         }
 
-        private void ProcessPendingBatch(string errorMessageOrNull, UnacknowledgedRenderBatch entry)
+        private void ProcessPendingBatch(string? errorMessageOrNull, UnacknowledgedRenderBatch entry)
         {
             var elapsedTime = entry.ValueStopwatch.GetElapsedTime();
             if (errorMessageOrNull == null)
@@ -324,11 +324,11 @@ private void ProcessPendingBatch(string errorMessageOrNull, UnacknowledgedRender
             CompleteRender(entry.CompletionSource, errorMessageOrNull);
         }
 
-        private void CompleteRender(TaskCompletionSource<object> pendingRenderInfo, string errorMessageOrNull)
+        private void CompleteRender(TaskCompletionSource pendingRenderInfo, string? errorMessageOrNull)
         {
             if (errorMessageOrNull == null)
             {
-                pendingRenderInfo.TrySetResult(null);
+                pendingRenderInfo.TrySetResult();
             }
             else
             {
@@ -338,7 +338,7 @@ private void CompleteRender(TaskCompletionSource<object> pendingRenderInfo, stri
 
         internal readonly struct UnacknowledgedRenderBatch
         {
-            public UnacknowledgedRenderBatch(long batchId, ArrayBuilder<byte> data, TaskCompletionSource<object> completionSource, ValueStopwatch valueStopwatch)
+            public UnacknowledgedRenderBatch(long batchId, ArrayBuilder<byte> data, TaskCompletionSource completionSource, ValueStopwatch valueStopwatch)
             {
                 BatchId = batchId;
                 Data = data;
@@ -348,7 +348,7 @@ public UnacknowledgedRenderBatch(long batchId, ArrayBuilder<byte> data, TaskComp
 
             public long BatchId { get; }
             public ArrayBuilder<byte> Data { get; }
-            public TaskCompletionSource<object> CompletionSource { get; }
+            public TaskCompletionSource CompletionSource { get; }
             public ValueStopwatch ValueStopwatch { get; }
         }
 

src/Components/Shared/src/ArrayBuilder.cs

@@ -18,7 +18,7 @@ namespace Microsoft.AspNetCore.Components.RenderTree
 {
     /// <summary>
     /// Implements a list that uses an array of objects to store the elements.
-    /// 
+    ///
     /// This differs from a <see cref="System.Collections.Generic.List{T}"/> in that
     /// it not only grows as required but also shrinks if cleared with significant
     /// excess capacity. This makes it useful for component rendering, because

src/DefaultBuilder/src/WebHost.cs

@@ -31,7 +31,7 @@ public static class WebHost
         /// <param name="app">A delegate that handles requests to the application.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
         public static IWebHost Start(RequestDelegate app) =>
-            Start(url: null, app: app);
+            Start(url: null!, app: app);
 
         /// <summary>
         /// Initializes and starts a new <see cref="IWebHost"/> with pre-configured defaults.
@@ -40,7 +40,7 @@ public static IWebHost Start(RequestDelegate app) =>
         /// <param name="url">The URL the hosted application will listen on.</param>
         /// <param name="app">A delegate that handles requests to the application.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
-        public static IWebHost Start(string? url, RequestDelegate app)
+        public static IWebHost Start(string url, RequestDelegate app)
         {
             var startupAssemblyName = app.GetMethodInfo().DeclaringType!.GetTypeInfo().Assembly.GetName().Name;
             return StartWith(url: url, configureServices: null, app: appBuilder => appBuilder.Run(app), applicationName: startupAssemblyName);
@@ -53,7 +53,7 @@ public static IWebHost Start(string? url, RequestDelegate app)
         /// <param name="routeBuilder">A delegate that configures the router for handling requests to the application.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
         public static IWebHost Start(Action<IRouteBuilder> routeBuilder) =>
-            Start(url: null, routeBuilder: routeBuilder);
+            Start(url: null!, routeBuilder: routeBuilder);
 
         /// <summary>
         /// Initializes and starts a new <see cref="IWebHost"/> with pre-configured defaults.
@@ -62,7 +62,7 @@ public static IWebHost Start(Action<IRouteBuilder> routeBuilder) =>
         /// <param name="url">The URL the hosted application will listen on.</param>
         /// <param name="routeBuilder">A delegate that configures the router for handling requests to the application.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
-        public static IWebHost Start(string? url, Action<IRouteBuilder> routeBuilder)
+        public static IWebHost Start(string url, Action<IRouteBuilder> routeBuilder)
         {
             var startupAssemblyName = routeBuilder.GetMethodInfo().DeclaringType!.GetTypeInfo().Assembly.GetName().Name;
             return StartWith(url, services => services.AddRouting(), appBuilder => appBuilder.UseRouter(routeBuilder), applicationName: startupAssemblyName);
@@ -75,7 +75,7 @@ public static IWebHost Start(string? url, Action<IRouteBuilder> routeBuilder)
         /// <param name="app">The delegate that configures the <see cref="IApplicationBuilder"/>.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
         public static IWebHost StartWith(Action<IApplicationBuilder> app) =>
-            StartWith(url: null, app: app);
+            StartWith(url: null!, app: app);
 
         /// <summary>
         /// Initializes and starts a new <see cref="IWebHost"/> with pre-configured defaults.
@@ -84,7 +84,7 @@ public static IWebHost StartWith(Action<IApplicationBuilder> app) =>
         /// <param name="url">The URL the hosted application will listen on.</param>
         /// <param name="app">The delegate that configures the <see cref="IApplicationBuilder"/>.</param>
         /// <returns>A started <see cref="IWebHost"/> that hosts the application.</returns>
-        public static IWebHost StartWith(string? url, Action<IApplicationBuilder> app) =>
+        public static IWebHost StartWith(string url, Action<IApplicationBuilder> app) =>
             StartWith(url: url, configureServices: null, app: app, applicationName: null);
 
         private static IWebHost StartWith(string? url, Action<IServiceCollection>? configureServices, Action<IApplicationBuilder> app, string? applicationName)
@@ -132,7 +132,7 @@ private static IWebHost StartWith(string? url, Action<IServiceCollection>? confi
         /// </remarks>
         /// <returns>The initialized <see cref="IWebHostBuilder"/>.</returns>
         public static IWebHostBuilder CreateDefaultBuilder() =>
-            CreateDefaultBuilder(args: null);
+            CreateDefaultBuilder(args: null!);
 
         /// <summary>
         /// Initializes a new instance of the <see cref="WebHostBuilder"/> class with pre-configured defaults.
@@ -153,7 +153,7 @@ public static IWebHostBuilder CreateDefaultBuilder() =>
         /// </remarks>
         /// <param name="args">The command line args.</param>
         /// <returns>The initialized <see cref="IWebHostBuilder"/>.</returns>
-        public static IWebHostBuilder CreateDefaultBuilder(string[]? args)
+        public static IWebHostBuilder CreateDefaultBuilder(string[] args)
         {
             var builder = new WebHostBuilder();
 

src/Hosting/Server.Abstractions/src/IServerIntegratedAuth.cs

@@ -16,6 +16,6 @@ public interface IServerIntegratedAuth
         /// <summary>
         /// The name of the authentication scheme for the server authentication handler.
         /// </summary>
-        string? AuthenticationScheme { get; }
+        string AuthenticationScheme { get; }
     }
 }

src/Hosting/Server.Abstractions/src/ServerIntegratedAuth.cs

@@ -16,6 +16,6 @@ public class ServerIntegratedAuth : IServerIntegratedAuth
         /// <summary>
         /// The name of the authentication scheme for the server authentication handler.
         /// </summary>
-        public string? AuthenticationScheme { get; set; }
+        public string AuthenticationScheme { get; set; } = default!;
     }
 }

src/Http/Authentication.Abstractions/src/AuthenticateResult.cs

@@ -98,7 +98,7 @@ public static AuthenticateResult NoResult()
         /// </summary>
         /// <param name="failure">The failure exception.</param>
         /// <returns>The result.</returns>
-        public static AuthenticateResult Fail(Exception? failure)
+        public static AuthenticateResult Fail(Exception failure)
         {
             return new AuthenticateResult() { Failure = failure };
         }
@@ -109,7 +109,7 @@ public static AuthenticateResult Fail(Exception? failure)
         /// <param name="failure">The failure exception.</param>
         /// <param name="properties">Additional state values for the authentication session.</param>
         /// <returns>The result.</returns>
-        public static AuthenticateResult Fail(Exception? failure, AuthenticationProperties? properties)
+        public static AuthenticateResult Fail(Exception failure, AuthenticationProperties? properties)
         {
             return new AuthenticateResult() { Failure = failure, Properties = properties };
         }
@@ -119,7 +119,7 @@ public static AuthenticateResult Fail(Exception? failure, AuthenticationProperti
         /// </summary>
         /// <param name="failureMessage">The failure message.</param>
         /// <returns>The result.</returns>
-        public static AuthenticateResult Fail(string? failureMessage)
+        public static AuthenticateResult Fail(string failureMessage)
             => Fail(new Exception(failureMessage));
 
         /// <summary>
@@ -128,7 +128,7 @@ public static AuthenticateResult Fail(string? failureMessage)
         /// <param name="failureMessage">The failure message.</param>
         /// <param name="properties">Additional state values for the authentication session.</param>
         /// <returns>The result.</returns>
-        public static AuthenticateResult Fail(string? failureMessage, AuthenticationProperties? properties)
+        public static AuthenticateResult Fail(string failureMessage, AuthenticationProperties? properties)
             => Fail(new Exception(failureMessage), properties);
     }
 }

src/Http/Authentication.Abstractions/src/AuthenticationToken.cs

@@ -12,11 +12,11 @@ public class AuthenticationToken
         /// <summary>
         /// Name.
         /// </summary>
-        public string? Name { get; set; }
+        public string Name { get; set; } = default!;
 
         /// <summary>
         /// Value.
         /// </summary>
-        public string? Value { get; set; }
+        public string Value { get; set; } = default!;
     }
 }

src/JSInterop/Microsoft.JSInterop/src/IJSInProcessRuntime.cs

@@ -15,6 +15,6 @@ public interface IJSInProcessRuntime : IJSRuntime
         /// <param name="identifier">An identifier for the function to invoke. For example, the value <c>"someScope.someFunction"</c> will invoke the function <c>window.someScope.someFunction</c>.</param>
         /// <param name="args">JSON-serializable arguments.</param>
         /// <returns>An instance of <typeparamref name="T"/> obtained by JSON-deserializing the return value.</returns>
-        T Invoke<T>(string identifier, params object[] args);
+        T Invoke<T>(string identifier, params object?[] args);
     }
 }

src/JSInterop/Microsoft.JSInterop/src/JSInProcessRuntime.cs

@@ -19,7 +19,7 @@ public abstract class JSInProcessRuntime : JSRuntime, IJSInProcessRuntime
         /// <param name="args">JSON-serializable arguments.</param>
         /// <returns>An instance of <typeparamref name="TValue"/> obtained by JSON-deserializing the return value.</returns>
         [return: MaybeNull]
-        public TValue Invoke<TValue>(string identifier, params object[] args)
+        public TValue Invoke<TValue>(string identifier, params object?[] args)
         {
             var resultJson = InvokeJS(identifier, JsonSerializer.Serialize(args, JsonSerializerOptions));
             if (resultJson is null)