Skip to content

[tests] update NUnit to 3.7.1 #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2017
Merged

[tests] update NUnit to 3.7.1 #973

merged 1 commit into from
Oct 26, 2017

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Oct 25, 2017

Context: https://github.com/nunit/nunit/releases/tag/3.7.1

The release notes for NUnit 3.7.1 mention a hang with parallelized
tests, so it is worth a try to see if updating fixes it.

Reverting 6687dac as well to see if we get a green build.

@dnfclas
Copy link

dnfclas commented Oct 25, 2017

@jonathanpeppers,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Oct 25, 2017 •
edited
Loading

No hang, but the tests I checked seemed to fail with the same thing:

    Task "ResolveSdks"
		Using task ResolveSdks from Xamarin.Android.Tasks.ResolveSdks, Xamarin.Android.Build.Tasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
		ResolveSdksTask:
		  AndroidApiLevel: 
		  AndroidSdkBuildToolsVersion: 23.0.0
		  AndroidSdkPath: 
		  AndroidNdkPath: 
		  ReferenceAssemblyPaths: 
		    /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/
		  TargetFrameworkVersion: v6.0
		  UseLatestAndroidPlatformSdk: True
		  SequencePointsMode: None
		  LintToolPath: 
/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : Error executing task ResolveSdks: Could not determine Android SDK location. Please provide `androidSdkPath`.
		Error executing task ResolveSdks: System.InvalidOperationException: Could not determine Android SDK location. Please provide `androidSdkPath`.
		  at Xamarin.Android.Tools.AndroidSdkInfo..ctor (System.Action`2[T1,T2] logger, System.String androidSdkPath, System.String androidNdkPath, System.String javaSdkPath) [0x0008e] in /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/external/xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/AndroidSdkInfo.cs:28 
		  at Xamarin.Android.Tasks.MonoAndroidHelper.RefreshAndroidSdk (System.String sdkPath, System.String ndkPath, System.String javaPath) [0x00021] in /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/src/Xamarin.Android.Build.Tasks/Utilities/MonoAndroidHelper.cs:111 
		  at Xamarin.Android.Tasks.ResolveSdks.RunTask () [0x001a0] in /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/ResolveSdksTask.cs:157 
		  at Xamarin.Android.Tasks.ResolveSdks.Execute () [0x00002] in /Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/ResolveSdksTask.cs:130 
		  at Microsoft.Build.BuildEngine.TaskEngine.Execute () [0x00000] in /Users/builder/data/lanes/4992/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/TaskEngine.cs:134 
		  at Microsoft.Build.BuildEngine.BuildTask.Execute () [0x0008d] in /Users/builder/data/lanes/4992/mono-mac-sdk/external/bockbuild/builds/mono-x64/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/BuildTask.cs:101 
		Done building target "_SetLatestTargetFrameworkVersion" in project "/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj" ("/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets"); "_CheckProjectItems" depends on it.
		Done building target "_CheckProjectItems" in project "/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj" ("/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets"); "Build" depends on it.
		Done building target "Build" in project "/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj" ("/Library/Frameworks/Mono.framework/Versions/5.4.0/lib/mono/xbuild/14.0/bin/Microsoft.Common.targets"); "SignAndroidPackage" depends on it.
		Done building target "SignAndroidPackage" in project "/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj" ("/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets").
		Target performance summary:
		     0.266 ms  _ReadPropertiesCache                                    1 calls
		     0.568 ms  _ValidateLinkMode                                       1 calls
		     2.997 ms  _SetupDesignTimeBuildForBuild                           1 calls
		     7.297 ms  _CheckForInvalidConfigurationAndPlatform                1 calls
		    25.561 ms  _CreatePropertiesCache                                  1 calls
		    37.604 ms  _GetReferenceAssemblyPaths                              1 calls
		   248.665 ms  _SetLatestTargetFrameworkVersion                        1 calls
		Tasks performance summary:
		     4.255 ms  WriteLinesToFile                                        1 calls
		    17.509 ms  MakeDir                                                 1 calls
		    37.525 ms  GetReferenceAssemblyPaths                               1 calls
		   242.210 ms  ResolveSdks                                             1 calls
		Build FAILED.
		Warnings:
		/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj (SignAndroidPackage) ->
			/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj:  warning : Target 'IncrementalClean', not found in the project
		Errors:
		/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/TestDebug/temp/BuildBasicApplication/UnnamedProject.csproj (SignAndroidPackage) ->
		/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets (_SetLatestTargetFrameworkVersion target) ->
			/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : Error executing task ResolveSdks: Could not determine Android SDK location. Please provide `androidSdkPath`.
			 1 Warning(s)
			 1 Error(s)
		Time Elapsed 00:00:00.8013090

akoeplinger
akoeplinger approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this locally and it fixes the hang for me, nice find!

The test failures look unrelated (and don't happen locally).

@dellis1972
Copy link
Contributor

dellis1972 commented Oct 25, 2017

build

@jonpryor
Copy link
Contributor

jonpryor commented Oct 25, 2017

Please rebase atop master/PR #977.

@jonathanpeppers
[tests] update NUnit to 3.7.1
4e808a9 
Context: https://github.com/nunit/nunit/releases/tag/3.7.1

The release notes for NUnit 3.7.1 mention a hang with parallelized
tests, so it is worth a try to see if updating fixes it.

Reverting 6687dac as well to see if we get a green build.
@akoeplinger
Copy link
Member

akoeplinger commented Oct 25, 2017

the test failures look unrelated :)

@jonpryor jonpryor merged commit 5c75043 into dotnet:master Oct 26, 2017
Redth pushed a commit to Redth/xamarin-android that referenced this pull request Oct 30, 2017
@jonathanpeppers @Redth
[tests] Update to NUnit 3.7.1 (dotnet#973)
3470d7e 
Context: https://github.com/nunit/nunit/releases/tag/3.7.1
Context: commit 6687dac

The release notes for NUnit 3.7.1 mention a hang with parallelized
tests, so it is worth a try to see if updating fixes it the hangs
that we experienced and tried to workaround in 6687dac.
@radekdoulik radekdoulik mentioned this pull request Nov 1, 2018
Closed
@jonathanpeppers jonathanpeppers deleted the nunit-3.7.1 branch April 26, 2023 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dellis1972 dellis1972 dellis1972 approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonathanpeppers @dnfclas @dellis1972 @jonpryor @akoeplinger