From 5237146065ce26cf8ec18abff271c3567258c30b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Tue, 24 Oct 2017 03:58:45 +0200 Subject: [PATCH] [Xamarin.Android.Build.Tasks] Correctly set build tools version in CheckSignApk test The test failed locally for me with: ``` /Users/alexander/dev/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : '/Users/alexander/Library/Developer/Xamarin/android-sdk-macosx/build-tools/23.0.0/apksigner' does not exist. You need to install android-sdk build-tools 26.0.1 or above. ``` which is weird since it's looking into the 23.0.0 build tools which doesn't have apksigner even though the test specifies build tools 26.0.1. Turns out the test had a typo, it used AndroidBuildToolsVersion instead of AndroidSdkBuildToolsVersion so it fell back to 23.0.0 :) --- .../Tests/Xamarin.Android.Build.Tests/PackagingTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs index 8e4a0b61fbb..321650da910 100644 --- a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs +++ b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs @@ -214,7 +214,7 @@ public void CheckSignApk ([Values(true, false)] bool useApkSigner) }; if (useApkSigner) { proj.SetProperty ("AndroidUseApkSigner", "true"); - proj.SetProperty ("AndroidBuildToolsVersion", "26.0.1"); + proj.SetProperty ("AndroidSdkBuildToolsVersion", "26.0.1"); } else { proj.RemoveProperty ("AndroidUseApkSigner"); }