Attempt to fix a macOS lib{c,m} link error #7891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 0e4c29a 0e4c29a introduced builds of two library stubs, for libc and libm libraries, to be used when no NDK is installed. It appears that it can sometimes cause these link errors: ld : error : undefined symbol: vtable for __cxxabiv1::__function_type_info [/Users/builder/azdo/_work/3/s/xamarin-android/src/monodroid/monodroid.csproj] >>> referenced by stub.cc >>> CMakeFiles/c.dir/libstub/stub.cc.o:(typeinfo for void ()) >>> the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction) >clang++ : error : linker command failed with exit code 1 (use -v to see invocation) [/Users/builder/azdo/_work/3/s/xamarin-android/src/monodroid/monodroid.csproj] The missing symbol suggests that the problem lies in the lack of RTTI infrastructure in the library stub. Attempt to mitigate the issue by disabling both exceptions and RTTI when building the stubs.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 17, 2023
* main:
[monodroid] Attempt to fix a macOS lib{c,m} link error (dotnet#7891)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0e4c29a
0e4c29a introduced builds of two library stubs, for libc
and libm libraries, to be used when no NDK is installed.
It appears that it can sometimes cause these link errors:
The missing symbol suggests that the problem lies in the
lack of RTTI infrastructure in the library stub. Attempt
to mitigate the issue by disabling both exceptions and
RTTI when building the stubs.