From 6e1e41074862e82b614bbc51037e46b80b72f1a6 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Thu, 17 Aug 2017 20:37:08 +0100 Subject: [PATCH] [Xamarin.Android.Build.Tasks] Seeing a new seemingly DesignTimeBuild related build failure when invoking the Rebuild msbuild target Context https://bugzilla.xamarin.com/show_bug.cgi?id=58682 The `$(DesignTimeBuild)` value was empty when running under mac. This cuases the error error MSB4044: The "GetAdditionalResourcesFromAssemblies" task was not given a value for the required parameter "DesignTimeBuild". So we need to make sure that the value is set before we get to `GetAdditionalResourcesFromAssemblies`. The reason we got the error is before we used `$(DesignTimeBuild)` only in conditionals. However when moving to use it as a property of a task it cannot be empty. So we need to make sure we call `_SetupDesignTimeBuildForBuild` early in the build process. --- src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets b/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets index 12c7308ded0..47c8a2533e0 100755 --- a/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets +++ b/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets @@ -1013,7 +1013,7 @@ because xbuild doesn't support framework reference assemblies. - +