From e61ee04624a047d06fedac9b5135feea77dbd9d3 Mon Sep 17 00:00:00 2001 From: Atsushi Eno Date: Thu, 11 Jan 2018 16:08:35 +0900 Subject: [PATCH] [enumification][Mono.Android] fix ChoiceMode enum generation. After the last API XML generation sanitization, ChoiceMode was removed because they were generated from AbsListView fields which DOES NOT EXIST in API Level 10. And getChoiceMode() and setChoiceMode are removed because they expect that nonexistent enum. Fortunately they are in ListView in API Level 10, so they can be generated from there. --- .../enumification-helpers/enum-conversion-mappings.xml | 3 ++- external/xamarin-android-api-compatibility | 2 +- src/Mono.Android/map.csv | 8 ++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/build-tools/enumification-helpers/enum-conversion-mappings.xml b/build-tools/enumification-helpers/enum-conversion-mappings.xml index 54d7db80813..1cb34889ca0 100644 --- a/build-tools/enumification-helpers/enum-conversion-mappings.xml +++ b/build-tools/enumification-helpers/enum-conversion-mappings.xml @@ -842,7 +842,8 @@ - + + diff --git a/external/xamarin-android-api-compatibility b/external/xamarin-android-api-compatibility index 6a262943294..6874e3f320b 160000 --- a/external/xamarin-android-api-compatibility +++ b/external/xamarin-android-api-compatibility @@ -1 +1 @@ -Subproject commit 6a26294329428a1369462bba32e91d5c83164994 +Subproject commit 6874e3f320bc263072214c9ae1527ae186e0d51d diff --git a/src/Mono.Android/map.csv b/src/Mono.Android/map.csv index daf14613097..34e6728913c 100644 --- a/src/Mono.Android/map.csv +++ b/src/Mono.Android/map.csv @@ -2967,10 +2967,6 @@ 27,Android.Webkit.SafeBrowsingThreat,Phishing,android/webkit/WebViewClient.SAFE_BROWSING_THREAT_PHISHING,2 27,Android.Webkit.SafeBrowsingThreat,Unknown,android/webkit/WebViewClient.SAFE_BROWSING_THREAT_UNKNOWN,0 27,Android.Webkit.SafeBrowsingThreat,UnwantedSoftware,android/webkit/WebViewClient.SAFE_BROWSING_THREAT_UNWANTED_SOFTWARE,3 -15,Android.Widget.ChoiceMode,Multiple,android/widget/AbsListView.CHOICE_MODE_MULTIPLE,2 -15,Android.Widget.ChoiceMode,MultipleModal,android/widget/AbsListView.CHOICE_MODE_MULTIPLE_MODAL,3 -15,Android.Widget.ChoiceMode,None,android/widget/AbsListView.CHOICE_MODE_NONE,0 -15,Android.Widget.ChoiceMode,Single,android/widget/AbsListView.CHOICE_MODE_SINGLE,1 10,Android.Widget.TranscriptMode,AlwaysScroll,android/widget/AbsListView.TRANSCRIPT_MODE_ALWAYS_SCROLL,2 10,Android.Widget.TranscriptMode,Disabled,android/widget/AbsListView.TRANSCRIPT_MODE_DISABLED,0 10,Android.Widget.TranscriptMode,Normal,android/widget/AbsListView.TRANSCRIPT_MODE_NORMAL,1 @@ -5095,6 +5091,10 @@ 27,Android.Views.FeedbackConstants,VirtualKeyRelease,android/view/HapticFeedbackConstants.VIRTUAL_KEY_RELEASE,8 10,Android.Views.FeedbackFlags,IgnoreGlobalSetting,android/view/HapticFeedbackConstants.FLAG_IGNORE_GLOBAL_SETTING,2 10,Android.Views.FeedbackFlags,IgnoreViewSetting,android/view/HapticFeedbackConstants.FLAG_IGNORE_VIEW_SETTING,1 +10,Android.Widget.ChoiceMode,Multiple,android/widget/ListView.CHOICE_MODE_MULTIPLE,2 +10,Android.Widget.ChoiceMode,None,android/widget/ListView.CHOICE_MODE_NONE,0 +10,Android.Widget.ChoiceMode,Single,android/widget/ListView.CHOICE_MODE_SINGLE,1 +15,Android.Widget.ChoiceMode,MultipleModal,android/widget/AbsListView.CHOICE_MODE_MULTIPLE_MODAL,3 24,Android.AccessibilityServices.AccessibilityServiceShowMode,Auto,android/accessibilityservice/AccessibilityService.SHOW_MODE_AUTO,0 24,Android.AccessibilityServices.AccessibilityServiceShowMode,Hidden,android/accessibilityservice/AccessibilityService.SHOW_MODE_HIDDEN,1 24,Android.App.Admin.BugReportFailureReason,FailedCompleting,android/app/admin/DeviceAdminReceiver.BUGREPORT_FAILURE_FAILED_COMPLETING,0