Bump LibZipSharp to bring upstream fixes #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Running `class-parse --dump` on `java.lang.Object` would fail: # on macOS, JDK 1.8 installed $ unzip /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/rt.jar java/lang/Object.class $ mono class-parse.exe --dump java/lang/Object.class ... class-parse: Unable to read file 'java/lang/Object.class': Object reference not set to an instance of an object Enabling verbose output (`class-parse -v`) didn't help: $ mono class-parse.exe -v --dump java/lang/Object.class Unhandled Exception: System.IndexOutOfRangeException: Index was outside the bounds of the array. at Mono.Options.Option.Parse[T] (System.String value, Mono.Options.OptionContext c) [0x0005e] in <4d78dd3d6bb745d7a994cb7587b83fb2>:0 ... Doh! The problem with the `IndexOutOfRangeException` is a bug in `Mono.Options-PCL.cs`: it should be using `GenericTypeArguments[0]`, *not* `GenericTypeParameters[0]`. Fix that. Once that is fixed, we see that the `NullReferenceException` is coming from accessing `ClassFile.SuperClass.Name`, because `java.lang.Object` *has no superclass*, and thus `ClassFile.SuperClass` returns `null`. Properly check for that. With those changes in place, `class-parse --dump java.lang.Object` works as intended: $ mono class-parse.exe --dump java/lang/Object.class .class version: 52.0 ... Methods Count: 12 ... 11: finalize ()V Protected Code(10, Unknown[LineNumberTable](6)) Exceptions(java/lang/Throwable)
jonpryor
pushed a commit
that referenced
this pull request
May 26, 2022
Changes: dotnet/android-tools@fc3c2ac...20f6112 * dotnet/android-tools@20f6112: Bump LibZipSharp to 2.0.4 (#166) * dotnet/android-tools@e4f0d59: Add support for writing android:roundIcon to Android manifest (#162) Changes: dotnet/android-libzipsharp@2.0.3...2.0.4 * dotnet/android-libzipsharp@8ac30f3: Bump Version to 2.0.4 for Release (#109) * dotnet/android-libzipsharp@8e22fe1: Use RuntimeInformation to determine the Processor architecture. (#108) * dotnet/android-libzipsharp@33f5b01: Bump vcpkg to latest version (#106) * dotnet/android-libzipsharp@6fd0a14: [ci] Use new EO compliant build pools (#107) * dotnet/android-libzipsharp@d339358: Add a new more complex unit test (#105) Other changes: * 32-bit `libZipSharpNative.dll` is now in `x86\libZipSharpNative.dll`. * 64-bit `lib64\libZipSharpNative.dll` is now in `x64\libZipSharpNative.dll`.
simonrozsival
pushed a commit
to simonrozsival/xamarin-android
that referenced
this pull request
May 31, 2022
Changes: dotnet/android-tools@fc3c2ac...20f6112 * dotnet/android-tools@20f6112: Bump LibZipSharp to 2.0.4 (dotnet#166) * dotnet/android-tools@e4f0d59: Add support for writing android:roundIcon to Android manifest (dotnet#162) Changes: dotnet/android-libzipsharp@2.0.3...2.0.4 * dotnet/android-libzipsharp@8ac30f3: Bump Version to 2.0.4 for Release (dotnet#109) * dotnet/android-libzipsharp@8e22fe1: Use RuntimeInformation to determine the Processor architecture. (dotnet#108) * dotnet/android-libzipsharp@33f5b01: Bump vcpkg to latest version (dotnet#106) * dotnet/android-libzipsharp@6fd0a14: [ci] Use new EO compliant build pools (dotnet#107) * dotnet/android-libzipsharp@d339358: Add a new more complex unit test (dotnet#105) Other changes: * 32-bit `libZipSharpNative.dll` is now in `x86\libZipSharpNative.dll`. * 64-bit `lib64\libZipSharpNative.dll` is now in `x64\libZipSharpNative.dll`.
jonathanpeppers
referenced
this pull request
in jonathanpeppers/xamarin-android
May 31, 2022
Changes: dotnet/android-tools@fc3c2ac...20f6112 * dotnet/android-tools@20f6112: Bump LibZipSharp to 2.0.4 (dotnet#166) * dotnet/android-tools@e4f0d59: Add support for writing android:roundIcon to Android manifest (dotnet#162) Changes: dotnet/android-libzipsharp@2.0.3...2.0.4 * dotnet/android-libzipsharp@8ac30f3: Bump Version to 2.0.4 for Release (#109) * dotnet/android-libzipsharp@8e22fe1: Use RuntimeInformation to determine the Processor architecture. (#108) * dotnet/android-libzipsharp@33f5b01: Bump vcpkg to latest version (#106) * dotnet/android-libzipsharp@6fd0a14: [ci] Use new EO compliant build pools (#107) * dotnet/android-libzipsharp@d339358: Add a new more complex unit test (#105) Other changes: * 32-bit `libZipSharpNative.dll` is now in `x86\libZipSharpNative.dll`. * 64-bit `lib64\libZipSharpNative.dll` is now in `x64\libZipSharpNative.dll`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.