From eed3528c1a425f85bee039217d0d925deabdd2ac Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Thu, 2 Nov 2017 14:16:17 +0000 Subject: [PATCH] [Xamarin.Android.ProjectTools] Fix logic error in native crash detection. Commit 855ad009 added logic to detect if a test had a native crash and to retry the test. There was a flaw in the logic such that it would run every test twice... This fixes that. --- .../Tests/Xamarin.ProjectTools/Common/Builder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs index 49c39b8ccfa..90741e1077f 100644 --- a/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs +++ b/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/Builder.cs @@ -281,7 +281,7 @@ protected bool BuildInternal (string projectOrSolution, string target, string [] sb.AppendFormat ("\n#stderr begin\n{0}\n#stderr end\n", p.StandardError.ReadToEnd ()); LastBuildOutput = sb.ToString (); - if (!nativeCrashDetected) { + if (nativeCrashDetected) { Console.WriteLine ($"Native crash detected! Running the build for {projectOrSolution} again."); continue; }