Parse cookies on redirect (#6987)

dominik-weber · web-flow · commit efb693f9426d · 2022-05-06T09:43:43.000Z
Fixes: #3954 When using the `AllowAutoRedirect` feature of `AndroidMessageHandler` to automatically follow 3xx redirects, the cookies that are returned together with the redirection are not processed. If the redirection target requires the cookies returned by the first request, the call will fail. This change fixes this behavior and always processes the cookies before the redirection takes place.
diff --git a/src/Mono.Android/Xamarin.Android.Net/AndroidMessageHandler.cs b/src/Mono.Android/Xamarin.Android.Net/AndroidMessageHandler.cs
@@ -582,12 +582,12 @@ internal Task WriteRequestContentToOutputInternal (HttpRequestMessage request, H
 					}
 				}
 
+				CopyHeaders (httpConnection, ret);
+				ParseCookies (ret, connectionUri);
+
 				if (disposeRet) {
 					ret.Dispose ();
 					ret = null!;
-				} else {
-					CopyHeaders (httpConnection, ret);
-					ParseCookies (ret, connectionUri);
 				}
 
 				// We don't want to pass the authorization header onto the next location

Original file line number	Diff line number	Diff line change
`@@ -582,12 +582,12 @@ internal Task WriteRequestContentToOutputInternal (HttpRequestMessage request, H`
`582`	`582`	`}`
`583`	`583`	`}`
`584`	`584`
	`585`	`+ CopyHeaders (httpConnection, ret);`
	`586`	`+ ParseCookies (ret, connectionUri);`
	`587`	`+`
`585`	`588`	`if (disposeRet) {`
`586`	`589`	`ret.Dispose ();`
`587`	`590`	`ret = null!;`
`588`		`- } else {`
`589`		`- CopyHeaders (httpConnection, ret);`
`590`		`- ParseCookies (ret, connectionUri);`
`591`	`591`	`}`
`592`	`592`
`593`	`593`	`// We don't want to pass the authorization header onto the next location`