Skip to content

Commit eefa61d

Browse files
committed
Revert "Use --types option when generating marshal methods for Mono.Android"
This reverts commit 66d34a1.
1 parent 7d7e2af commit eefa61d

File tree

3 files changed

+1
-29
lines changed

3 files changed

+1
-29
lines changed

src/Mono.Android/Mono.Android.jnimarshalmethods.types

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/Mono.Android/Mono.Android.targets

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -167,17 +167,4 @@
167167
AfterTargets="Clean">
168168
<RemoveDir Directories="$(IntermediateOutputPath)" />
169169
</Target>
170-
<PropertyGroup>
171-
<_JniMarshalMethodsTypesFile>Mono.Android.jnimarshalmethods.types</_JniMarshalMethodsTypesFile>
172-
<_JniMarshalMethodsTypesInstallDirectory>$(XAInstallPrefix)xbuild\Xamarin\Android</_JniMarshalMethodsTypesInstallDirectory>
173-
</PropertyGroup>
174-
<Target Name="_CopyJniMarshalMethodsTypesFile"
175-
BeforeTargets="CoreCompile"
176-
Inputs="$(_JniMarshalMethodsTypesFile)"
177-
Outputs="$(_JniMarshalMethodsTypesInstallDirectory)\$(_JniMarshalMethodsTypesFile)">
178-
<Copy
179-
SourceFiles="$(_JniMarshalMethodsTypesFile)"
180-
DestinationFolder="$(_JniMarshalMethodsTypesInstallDirectory)"
181-
/>
182-
</Target>
183170
</Project>

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,8 +308,6 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
308308
<_AndroidBuildPropertiesCache>$(IntermediateOutputPath)build.props</_AndroidBuildPropertiesCache>
309309
<_AndroidDesignTimeBuildPropertiesCache>$(_AndroidIntermediateDesignTimeBuildDirectory)build.props</_AndroidDesignTimeBuildPropertiesCache>
310310
<AndroidGenerateJniMarshalMethods Condition=" '$(AndroidGenerateJniMarshalMethods)' == '' ">False</AndroidGenerateJniMarshalMethods>
311-
<AndroidMonoAndroidJniMarshalTypesEnabled Condition=" '$(AndroidMonoAndroidJniMarshalTypesEnabled)' == '' ">True</AndroidMonoAndroidJniMarshalTypesEnabled>
312-
<AndroidMonoAndroidJniMarshalTypes Condition=" '$(AndroidMonoAndroidJniMarshalTypes)' == '' ">$(MonoAndroidToolsDirectory)\Mono.Android.jnimarshalmethods.types</AndroidMonoAndroidJniMarshalTypes>
313311
<AndroidMakeBundleKeepTemporaryFiles Condition=" '$(AndroidMakeBundleKeepTemporaryFiles)' == '' ">False</AndroidMakeBundleKeepTemporaryFiles>
314312
</PropertyGroup>
315313

@@ -2073,11 +2071,8 @@ because xbuild doesn't support framework reference assemblies.
20732071
<Exec
20742072
Command="MONO_PATH=&quot;$(_XATargetFrameworkDirectories)&quot; &quot;$(MonoAndroidBinDirectory)\mono&quot; &quot;$(MonoAndroidToolsDirectory)\jnimarshalmethod-gen.exe&quot; --jvm=&quot;$(JdkJvmPath)&quot; @(ResolvedUserAssemblies->'&quot;$(MonoAndroidLinkerInputDir)%(Filename)%(Extension)&quot;', ' ')"
20752073
/>
2076-
<PropertyGroup>
2077-
<_MonoAndroidJniMarshalMethodsTypesOption Condition=" '$(AndroidMonoAndroidJniMarshalTypesEnabled)' == 'True' ">--types=&quot;$(AndroidMonoAndroidJniMarshalTypes)&quot;</_MonoAndroidJniMarshalMethodsTypesOption>
2078-
</PropertyGroup>
20792074
<Exec
2080-
Command="MONO_PATH=&quot;$(_XATargetFrameworkDirectories)&quot; &quot;$(MonoAndroidBinDirectory)\mono&quot; &quot;$(MonoAndroidToolsDirectory)\jnimarshalmethod-gen.exe&quot; --jvm=&quot;$(JdkJvmPath)&quot; $(_MonoAndroidJniMarshalMethodsTypesOption) @(ResolvedAssemblies->'&quot;$(MonoAndroidLinkerInputDir)%(Filename)%(Extension)&quot;', ' ')"
2075+
Command="MONO_PATH=&quot;$(_XATargetFrameworkDirectories)&quot; &quot;$(MonoAndroidBinDirectory)\mono&quot; &quot;$(MonoAndroidToolsDirectory)\jnimarshalmethod-gen.exe&quot; --jvm=&quot;$(JdkJvmPath)&quot; @(ResolvedAssemblies->'&quot;$(MonoAndroidLinkerInputDir)%(Filename)%(Extension)&quot;', ' ')"
20812076
Condition=" '%(ResolvedAssemblies.Filename)' == 'Mono.Android' "
20822077
/>
20832078
<Touch Files="$(_AndroidJniMarshalMethodsFlag)" AlwaysCreate="True" />

0 commit comments

Comments
 (0)