Skip to content

Commit ee42973

Browse files
committed
Feedback updates
1 parent d00b5ed commit ee42973

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/Xamarin.Android.Build.Tasks/Properties/Resources.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1063,7 +1063,7 @@ To use a custom JDK path for a command line build, set the 'JavaSdkDirectory' MS
10631063
{1} - NuGet package version</comment>
10641064
</data>
10651065
<data name="XA0141" xml:space="preserve">
1066-
<value>Shared library '{3}' is not correctly aligned. You may wish to inform the creators of the NuGet/Library about this issue. The shared library is from NuGet package '{0}' version '{1}' and contains '{2}'. See https://developer.android.com/guide/practices/page-sizes for more details.</value>
1066+
<value>Shared library '{3}' must use 16 KB page sizes. Please inform the authors of the NuGet package '{0}' version '{1}' which contains '{2}'. See https://developer.android.com/guide/practices/page-sizes for more details.</value>
10671067
<comment>The following is a literal name and should not be translated: NuGet
10681068
{0} - NuGet package id
10691069
{1} - NuGet package version

src/Xamarin.Android.Build.Tasks/Tasks/GetImportedLibraries.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ public override bool RunTask ()
4949
if (file.EndsWith (".so", StringComparison.OrdinalIgnoreCase)) {
5050
if (AndroidRidAbiHelper.GetNativeLibraryAbi (file) != null)
5151
nativeLibraries.Add (new TaskItem (file, new Dictionary<string, string> {
52-
{ ResolveLibraryProjectImports.OriginalFile, originalFile },
53-
{ ResolveLibraryProjectImports.NuGetPackageId, nuGetPackageId },
54-
{ ResolveLibraryProjectImports.NuGetPackageVersion, nuGetPackageVersion }
52+
[ResolveLibraryProjectImports.OriginalFile] = originalFile,
53+
[ResolveLibraryProjectImports.NuGetPackageId] = nuGetPackageId,
54+
[ResolveLibraryProjectImports.NuGetPackageVersion] = nuGetPackageVersion,
5555
}));
5656
continue;
5757
}
5858
if (file.EndsWith (".jar", StringComparison.OrdinalIgnoreCase)) {
5959
jarFiles.Add (new TaskItem (file, new Dictionary<string, string> {
60-
{ ResolveLibraryProjectImports.OriginalFile, originalFile },
61-
{ ResolveLibraryProjectImports.NuGetPackageId, nuGetPackageId },
62-
{ ResolveLibraryProjectImports.NuGetPackageVersion, nuGetPackageVersion }
60+
[ResolveLibraryProjectImports.OriginalFile] = originalFile,
61+
[ResolveLibraryProjectImports.NuGetPackageId] = nuGetPackageId,
62+
[ResolveLibraryProjectImports.NuGetPackageVersion] = nuGetPackageVersion,
6363
}));
6464
continue;
6565
}
@@ -76,9 +76,9 @@ public override bool RunTask ()
7676
continue;
7777
}
7878
manifestDocuments.Add (new TaskItem (file, new Dictionary<string, string> {
79-
{ ResolveLibraryProjectImports.OriginalFile, originalFile },
80-
{ ResolveLibraryProjectImports.NuGetPackageId, nuGetPackageId },
81-
{ ResolveLibraryProjectImports.NuGetPackageVersion, nuGetPackageVersion }
79+
[ResolveLibraryProjectImports.OriginalFile] = originalFile,
80+
[ResolveLibraryProjectImports.NuGetPackageId] = nuGetPackageId,
81+
[ResolveLibraryProjectImports.NuGetPackageVersion] = nuGetPackageVersion,
8282
}));
8383
}
8484
}

0 commit comments

Comments
 (0)