You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[tests] InstallAndroidDependenciesTest can use platform-tools 34.0.0 (#7800)
We are seeing the `InstallAndroidDependenciesTest` test fail allot
recently. Looking at the logs we see the following warning.
warning : Dependency `platform-tools` should have been installed but could not be resolved. You can attempt to install it with:
/Users/dean/Documents/Sandbox/Xamarin/WI1714603/bin/TestRelease/temp/InstallAndroidDependenciesTest/android-sdk/cmdline-tools/7.0/lib/sdkmanager-classpath.jar --install "platform-tools"
As a result `platform-tools` is not installed. This causes the
`ResolveSdks` task to ignore the test sdk directory because `adb` is
missing. So lets update the `AndroidSdkPlatformToolsVersion ` to use
one that does work.
"AndroidManifestType=GoogleV2",// Need GoogleV2 so we can install API-32
42
-
"AndroidSdkPlatformToolsVersion=33.0.3",
42
+
"AndroidSdkPlatformToolsVersion=34.0.0",
43
43
}),"InstallAndroidDependencies should have succeeded.");
44
44
b.Target=defaultTarget;
45
45
b.BuildLogFile="build.log";
46
46
Assert.IsTrue(b.Build(proj,true),"build should have succeeded.");
47
-
Assert.IsTrue(b.LastBuildOutput.ContainsText($"Output Property: _AndroidSdkDirectory={sdkPath}"),"_AndroidSdkDirectory was not set to new SDK path.");
48
-
Assert.IsTrue(b.LastBuildOutput.ContainsText($"JavaPlatformJarPath={sdkPath}"),"JavaPlatformJarPath did not contain new SDK path.");
47
+
Assert.IsTrue(b.LastBuildOutput.ContainsText($"Output Property: _AndroidSdkDirectory={sdkPath}"),$"_AndroidSdkDirectory was not set to new SDK path `{sdkPath}`.");
48
+
Assert.IsTrue(b.LastBuildOutput.ContainsText($"JavaPlatformJarPath={sdkPath}"),$"JavaPlatformJarPath did not contain new SDK path `{sdkPath}`.");
0 commit comments