Skip to content

Commit b0f5393

Browse files
committed
Some optimizations
1 parent a4d5ce7 commit b0f5393

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Assets.targets

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
3434
<PropertyGroup>
3535
<BeforeBuildAndroidAssetPacks>
3636
UpdateAndroidAssets
37+
;_CalculateAssetsWithAssetPackMetaData
3738
;_CalculateAssetPacks
3839
;$(BeforeBuildAndroidAssetPacks)
3940
;_CreateAssetPackManifests
@@ -74,22 +75,23 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
7475
</ItemGroup>
7576
</Target>
7677

77-
<Target Name="_CheckForAssetPackInLibraryProject" Condition=" '$(AndroidApplication)' != 'true' ">
78+
<Target Name="_CalculateAssetsWithAssetPackMetaData">
7879
<ItemGroup>
7980
<_AssetsWithAssetPackMetaData Include="@(AndroidAsset)" Condition=" '%(AndroidAsset.AssetPack)' != '' " />
8081
</ItemGroup>
8182
<AndroidError
8283
Code="XA0138"
8384
ResourceName="XA0138"
84-
Condition=" '@(_AssetsWithAssetPackMetaData->Count())' != '0' "
85+
Condition=" '$(AndroidApplication)' != 'true' And '@(_AssetsWithAssetPackMetaData->Count())' != '0' "
8586
/>
8687
</Target>
8788

8889
<Target Name="_CalculateAssetPacks"
90+
DependsOnTargets="_CalculateAssetsWithAssetPackMetaData"
8991
Condition=" ('$(AndroidPackageFormat)' == 'aab' And '$(AndroidApplication)' == 'true') "
9092
>
9193
<!-- Enumerate the assetpacks directory and build a pack per top level directory -->
92-
<GetAssetPacks Assets="@(AndroidAsset)" IntermediateDir="$(MonoAndroidAssetPacksDirIntermediate)">
94+
<GetAssetPacks Assets="@(_AssetsWithAssetPackMetaData)" IntermediateDir="$(MonoAndroidAssetPacksDirIntermediate)">
9395
<Output ItemName="_AndroidAsset" TaskParameter="AssetPacks" />
9496
</GetAssetPacks>
9597
<ItemGroup>

src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.BuildOrder.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ properties that determine build ordering.
9292
_AddAndroidDefines;
9393
_CheckForContent;
9494
_CheckForObsoleteFrameworkAssemblies;
95-
_CheckForAssetPackInLibraryProject;
95+
_CalculateAssetsWithAssetPackMetaData;
9696
_RemoveLegacyDesigner;
9797
_ValidateAndroidPackageProperties;
9898
AddLibraryJarsToBind;

0 commit comments

Comments
 (0)