Skip to content

Commit a08f885

Browse files
akoeplingerjonpryor
authored andcommitted
[Xamarin.Android.Build.Tasks] Correctly set build tools version in CheckSignApk test (#966)
The test failed locally for me with: ``` …/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : '…/android-sdk-macosx/build-tools/23.0.0/apksigner' does not exist. You need to install android-sdk build-tools 26.0.1 or above. ``` which is weird since it's looking into the 23.0.0 build tools which doesn't have apksigner even though the test specifies build tools 26.0.1. Turns out the test had a typo, it used `AndroidBuildToolsVersion` instead of `AndroidSdkBuildToolsVersion` so it fell back to 23.0.0 :)
1 parent c2fbd79 commit a08f885

File tree

1 file changed

+1
-1
lines changed
  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests

1 file changed

+1
-1
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/PackagingTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public void CheckSignApk ([Values(true, false)] bool useApkSigner)
214214
};
215215
if (useApkSigner) {
216216
proj.SetProperty ("AndroidUseApkSigner", "true");
217-
proj.SetProperty ("AndroidBuildToolsVersion", "26.0.1");
217+
proj.SetProperty ("AndroidSdkBuildToolsVersion", "26.0.1");
218218
} else {
219219
proj.RemoveProperty ("AndroidUseApkSigner");
220220
}

0 commit comments

Comments
 (0)