Skip to content

Commit 9530fd0

Browse files
pjcollinsjonpryor
authored andcommitted
[ci] Report artifact status to the correct repo (#4097)
The `notarize_pkg_upload_storage` job is responsible for posting artifact metadata to GitHub as a commit status, and the `.vsix` signing performed by the `queue_vsix_signing` job depends upon the presence of this GitHub status. Commit ed29bf1 broke the posting of the status, as it changed the source checkout behavior for this job. We report artifact metadata to GitHub with the [Artifacts tool][0], and this tool must be ran inside the source directory that it is going to create a GitHub commit status for. With ed29bf1, we started executing this tool within a `release-scripts` checkout rather than a `xamarin-android` checkout. This change meant that the required status was no longer being posted, which in turn caused the `queue_vsix_signing` job to always fail. Fix the `queue_vsix_signing` job by cloning both the xamarin-android and release-scripts repos so that the artifacts tool can run within the xamarin-android checkout and successfully report a status back to it. [0]: https://github.com/xamarinhq/build-tasks/tree/master/Artifacts
1 parent 07cc8cb commit 9530fd0

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

build-tools/automation/azure-pipelines.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,8 @@ stages:
332332
variables:
333333
- group: Xamarin Notarization
334334
steps:
335+
- checkout: self
336+
335337
- checkout: release_scripts
336338
clean: true
337339
persistCredentials: true
@@ -361,6 +363,7 @@ stages:
361363
UnsignedPkgPath: $(XA.Unsigned.Pkg)
362364

363365
- script: |
366+
cd $(System.DefaultWorkingDirectory)/release-scripts
364367
git checkout $(ReleaseScriptsBranch)
365368
sudo xcode-select -s /Applications/$(NotarizationXcode)
366369
ruby notarize.rb $(XA.Unsigned.Pkg) $(XamarinIdentifier) $(XamarinUserId) $(XamarinPassword) $(TeamID)
@@ -374,6 +377,7 @@ stages:
374377
BuildPackages: $(System.DefaultWorkingDirectory)/storage-artifacts
375378
AzureContainerName: $(Azure.Container.Name)
376379
AzureUploadLocation: $(Build.DefinitionName)/$(Build.BuildId)/$(Build.SourceBranchName)/$(Build.SourceVersion)
380+
SourceDirectory: $(System.DefaultWorkingDirectory)/xamarin-android
377381

378382
- script: cp $(System.DefaultWorkingDirectory)/storage-artifacts/*.pkg $(Build.ArtifactStagingDirectory)
379383
displayName: copy notarized pkg

0 commit comments

Comments
 (0)