Add System.ComponentModel.EditorBrowsableAttribute

Author: dellis1972

src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesignerAssembly.cs

@@ -103,20 +103,25 @@ bool Run(DirectoryAssemblyResolver res)
 			} else {
 				// Add the InternalsVisibleToAttribute so the app can access ResourceConstant
 				if (!string.IsNullOrEmpty (AssemblyName)) {
-					MethodReference internalsVisibleToAttributeConstructor = ImportCustomAttributeConstructor ("System.Runtime.CompilerServices.InternalsVisibleToAttribute", module, netstandardDef.MainModule);
+					MethodReference internalsVisibleToAttributeConstructor = ImportCustomAttributeConstructor ("System.Runtime.CompilerServices.InternalsVisibleToAttribute", module, netstandardDef.MainModule, argCount: 1);
 					var ar = new CustomAttribute (internalsVisibleToAttributeConstructor);
 					ar.ConstructorArguments.Add (new CustomAttributeArgument (module.TypeSystem.String, AssemblyName));
 					module.Assembly.CustomAttributes.Add (ar);
 				}
 			}
 
-			MethodReference targetFrameworkConstructor = ImportCustomAttributeConstructor ("System.Runtime.Versioning.TargetFrameworkAttribute", module, netstandardDef.MainModule);
+			MethodReference targetFrameworkConstructor = ImportCustomAttributeConstructor ("System.Runtime.Versioning.TargetFrameworkAttribute", module, netstandardDef.MainModule, argCount: 1);
 
 			var attr = new CustomAttribute (targetFrameworkConstructor);
 			attr.ConstructorArguments.Add (new CustomAttributeArgument (module.TypeSystem.String, $".NETStandard,Version=v2.1"));
 			attr.Properties.Add (new CustomAttributeNamedArgument ("FrameworkDisplayName", new CustomAttributeArgument (module.TypeSystem.String, "")));
 			module.Assembly.CustomAttributes.Add (attr);
 
+			MethodReference editorBrowserConstructor = ImportCustomAttributeConstructor ("System.ComponentModel.EditorBrowsableAttribute", module, netstandardDef.MainModule, argCount: 1);
+			TypeReference e = ImportType ("System.ComponentModel.EditorBrowsableState", module, netstandardDef.MainModule);
+			var editorBrowserAttr = new CustomAttribute (editorBrowserConstructor);
+			editorBrowserAttr.ConstructorArguments.Add (new CustomAttributeArgument (e, System.ComponentModel.EditorBrowsableState.Never));
+
 			var att = TypeAttributes.AutoClass | TypeAttributes.AnsiClass | TypeAttributes.Public | TypeAttributes.BeforeFieldInit;
 
 			intArray = new ArrayType (module.TypeSystem.Int32);
@@ -131,6 +136,7 @@ bool Run(DirectoryAssemblyResolver res)
 				objectRef
 			);
 			CreateCtor (resourceDesigner, module);
+			resourceDesigner.CustomAttributes.Add (editorBrowserAttr);
 			module.Types.Add (resourceDesigner);
 			TypeDefinition constDesigner = null;
 			if (IsApplication) {
@@ -143,6 +149,7 @@ bool Run(DirectoryAssemblyResolver res)
 					objectRef
 				);
 				CreateCtor (constDesigner, module);
+				constDesigner.CustomAttributes.Add (editorBrowserAttr);
 				module.Types.Add (constDesigner);
 			}
 
@@ -196,11 +203,16 @@ bool Run(DirectoryAssemblyResolver res)
 			return !Log.HasLoggedErrors;
 		}
 
-		MethodReference ImportCustomAttributeConstructor (string type, ModuleDefinition module, ModuleDefinition sourceModule = null)
+		MethodReference ImportCustomAttributeConstructor (string type, ModuleDefinition module, ModuleDefinition sourceModule = null, int argCount = 0)
 		{
 			var tr = module.ImportReference ((sourceModule ?? module).ExportedTypes.First(x => x.FullName == type).Resolve ());
 			var tv = tr.Resolve();
-			return module.ImportReference (tv.Methods.First(x => x.IsConstructor));
+			return module.ImportReference (tv.Methods.First(x => x.IsConstructor && (x.Parameters?.Count ?? 0) == argCount));
+		}
+
+		TypeReference ImportType (string type, ModuleDefinition module, ModuleDefinition sourceModule = null)
+		{
+			return module.ImportReference ((sourceModule ?? module).ExportedTypes.First(x => x.FullName == type).Resolve ());
 		}
 
 		void CreateIntProperty (string resourceClass, string propertyName, int value, TypeDefinition resourceDesigner, ModuleDefinition module,