[Xamarin.Android.Build.Tasks] Fix VS DesignTime Build Hang (#985)

FixesL https://bugzilla.xamarin.com/show_bug.cgi?id=60080

In a previous attempt to fix an intellisense build (1cd582e) we
caused this issue. The DesignTime build does NOT like our AsyncTask
as it locks the IDE.

This commit puts the old code back in place which skips the task
if we are in DesignTime mode. But so we can easily test it, we
emit an message that our test can pick up to ensure we are doing
the correct thing. Without the message we have no way of knowing
if the task is skipped.

Author: dellis1972

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs

@@ -84,7 +84,7 @@ public void DesignTimeBuild ([Values(false, true)] bool isRelease, [Values (fals
 					Assert.IsTrue (b.Clean(proj), "App should have cleaned successfully");
 					Assert.IsTrue (b.UpdateAndroidResources (proj, doNotCleanupOnUpdate: true, parameters: new string [] { "DesignTimeBuild=true" }, environmentVariables: envVar),
 						"first build failed");
-					Assert.AreEqual (!useManagedParser, b.LastBuildOutput.Contains ("Skipping download of "),
+					Assert.AreEqual (!useManagedParser, b.LastBuildOutput.Contains ("Skipping GetAdditionalResourcesFromAssemblies"),
 						"failed to skip the downloading of files.");
 					var items = new List<string> ();
 					string first = null;

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Bindings.targets

@@ -278,7 +278,9 @@ Copyright (C) 2012 Xamarin Inc. All rights reserved.
       CacheFile="$(IntermediateOutputPath)resourcepaths.cache"
       YieldDuringToolExecution="$(YieldDuringToolExecution)"
       DesignTimeBuild="$(DesignTimeBuild)"
+      Condition=" '$(DesignTimeBuild)' == '' Or '$(DesignTimeBuild)' == 'false' "
     />
+  <Message Text="Skipping GetAdditionalResourcesFromAssemblies in DesignTime build" Condition=" '$(DesignTimeBuild)' == 'true' " />
   </Target>
 
   <Target Name="_GetAdditionalResourcesFromAssemblies" DependsOnTargets="_BuildAdditionalResourcesCache">

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

@@ -407,7 +407,9 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
    YieldDuringToolExecution="$(YieldDuringToolExecution)"
    DesignTimeBuild="$(DesignTimeBuild)"
    ContinueOnError="$(DesignTimeBuild)"
+   Condition=" '$(DesignTimeBuild)' == '' Or '$(DesignTimeBuild)' == 'false' "
   />
+  <Message Text="Skipping GetAdditionalResourcesFromAssemblies in DesignTime build" Condition=" '$(DesignTimeBuild)' == 'true' " />
 </Target>
 
 <Target Name="_ValidateResourceCache">