Skip to content

Commit 6e1e410

Browse files
committed
[Xamarin.Android.Build.Tasks] Seeing a new seemingly DesignTimeBuild related build failure when invoking the Rebuild msbuild target
Context https://bugzilla.xamarin.com/show_bug.cgi?id=58682 The `$(DesignTimeBuild)` value was empty when running under mac. This cuases the error error MSB4044: The "GetAdditionalResourcesFromAssemblies" task was not given a value for the required parameter "DesignTimeBuild". So we need to make sure that the value is set before we get to `GetAdditionalResourcesFromAssemblies`. The reason we got the error is before we used `$(DesignTimeBuild)` only in conditionals. However when moving to use it as a property of a task it cannot be empty. So we need to make sure we call `_SetupDesignTimeBuildForBuild` early in the build process.
1 parent bafb47c commit 6e1e410

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@ because xbuild doesn't support framework reference assemblies.
10131013
</ReadLinesFromFile>
10141014
</Target>
10151015

1016-
<Target Name="_CreatePropertiesCache" DependsOnTargets="_ReadPropertiesCache">
1016+
<Target Name="_CreatePropertiesCache" DependsOnTargets="_SetupDesignTimeBuildForBuild;_ReadPropertiesCache">
10171017
<MakeDir Directories="$(IntermediateOutputPath)" Condition="!Exists('$(IntermediateOutputPath)')" />
10181018
<WriteLinesToFile
10191019
Condition="'@(_PropertiesCache)' != '@(_PropertyCacheItems)'"

0 commit comments

Comments
 (0)