-
Notifications
You must be signed in to change notification settings - Fork 564
Commit 320ae78
committed
[api-compatibility] Update for platform-tools 29.0.5
Android SDK Platform-Tools 29.0.5 contains changes to the
`api-versions.xml` file compared to Android SDK Platform-Tools 29.0.1.
`generator.exe` uses `api-versions.xml` as an input when generating the
C# bindings, so this change causes the API compatibility check in
`Mono.Android.csproj` to fail. Excerpt of the errors:
AfterBuild:
CheckApiCompatibility for ApiLevel: v10.0
CompatApi command: ../../packages/Microsoft.DotNet.ApiCompat.5.0.0-beta.19606.1/tools/net472/Microsoft.DotNet.ApiCompat.exe "../../tests/api-compatibility\reference\ApiCompatTemp" -i "F:\A\xamarin-v000006-1\_work\2\s\bin\Release\lib\xamarin.android\xbuild-frameworks\MonoAndroid\v10.0\ApiCompatTemp" --exclude-attributes ../../tests/api-compatibility\api-compat-exclude-attributes.txt
Compat issues with assembly Mono.Android:
CannotChangeAttribute : Attribute 'Android.Runtime.RegisterAttribute' on 'System.String Android.Manifest.Permission.AccessBackgroundLocation' changed from '[RegisterAttribute("ACCESS_BACKGROUND_LOCATION")]' in the contract to '[RegisterAttribute("ACCESS_BACKGROUND_LOCATION", ApiSince=29)]' in the implementation.
CannotChangeAttribute : Attribute 'Android.Runtime.RegisterAttribute' on 'System.String Android.Manifest.Permission.AccessMediaLocation' changed from '[RegisterAttribute("ACCESS_MEDIA_LOCATION")]' in the contract to '[RegisterAttribute("ACCESS_MEDIA_LOCATION", ApiSince=29)]' in the implementation.
CannotChangeAttribute : Attribute 'Android.Runtime.RegisterAttribute' on 'System.String Android.Manifest.Permission.ActivityRecognition' changed from '[RegisterAttribute("ACTIVITY_RECOGNITION")]' in the contract to '[RegisterAttribute("ACTIVITY_RECOGNITION", ApiSince=29)]' in the implementation.
Excerpt of the diff of `api-versions.xml` showing where these changes
came from:
--- "a/platform-tools-29.0.1\\api\\api-versions.xml"
+++ "b/platform-tools-29.0.5\\api\\api-versions.xml"
@@ -10,0 +11 @@
+ <field name="ACCESS_BACKGROUND_LOCATION" since="29"/>
@@ -14,0 +16 @@
+ <field name="ACCESS_MEDIA_LOCATION" since="29"/>
@@ -20,0 +23 @@
+ <field name="ACTIVITY_RECOGNITION" since="29"/>
To address this, update the list of expected API breakages in
`acceptable-breakages-vReference.txt`.1 parent 98c152e commit 320ae78Copy full SHA for 320ae78
File tree
Expand file treeCollapse file tree
1 file changed
+1270
-1
lines changedOpen diff view settings
Filter options
- tests/api-compatibility
Expand file treeCollapse file tree
1 file changed
+1270
-1
lines changedOpen diff view settings
0 commit comments