Skip to content

Commit 2bca09d

Browse files
jonathanpeppersjonpryor
authored andcommitted
[create-vsix] Fix build ordering for xa-prep-tasks on Windows (#836)
Context: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=978440&_a=summary On Windows the following scenario is happening: - `_CreateDependencies` (and `GetXAVersionInfo`) load xa-prep-tasks.dll - This locks the assembly (on Windows only) - `<ProjectReference/>` causes xa-prep-tasks to build, but the output assembly is locked - There is also an issue here if xa-prep-tasks is not built yet, as MSBuild tasks are used from it. The fix is to add a `DependsOnTargets` for `ResolveAssemblies`, this builds xa-prep-tasks before using it.
1 parent 46d4040 commit 2bca09d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build-tools/create-vsix/create-vsix.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
Returns="$(IsExperimental)">
100100
</Target>
101101
<Target Name="_CreateDependencies"
102-
DependsOnTargets="GetXAVersionInfo"
102+
DependsOnTargets="ResolveReferences;GetXAVersionInfo"
103103
BeforeTargets="Build"
104104
Inputs="Xamarin.Android.Sdk.pkgdef.in"
105105
Outputs="Xamarin.Android.Sdk.pkgdef">

0 commit comments

Comments
 (0)