Skip to content

Commit 286feea

Browse files
dellis1972jonpryor
authored andcommitted
[Xamarin.Android.Build.Tasks] IDE0006 warning on File -> New CrossPlatform App (#730)
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=58448 Based on feedback from the VS team we now know that library projects are NEVER built as part of a DesignTimeBuild :(. Furthermore, if ANY error occurs during the DesignTimeBuild VS throws a wobbly and does not initialise the project correctly. The suggestion is to use `ContinueOnError` to ignore the errors and allow the build to complete.
1 parent d525c47 commit 286feea

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Common/ImportAfter/Microsoft.Cpp.Android.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Copyright (C) 2014 Xamarin. All rights reserved.
5252
<Output TaskParameter="TargetOutputs" ItemName="_NativeAndroidRecipeFiles"/>
5353
</MSBuild>
5454

55-
<MergeApkRecipelists RecipeFiles="@(_NativeAndroidRecipeFiles)" Condition="'@(_NativeAndroidRecipeFiles)' != ''">
55+
<MergeApkRecipelists RecipeFiles="%(_NativeAndroidRecipeFiles.Identity)" Condition="'@(_NativeAndroidRecipeFiles)' != '' And Exists('%(_NativeAndroidRecipeFiles.Identity)')">
5656
<Output TaskParameter="SOLibPaths" ItemName="NativeLibraryPaths" />
5757
<Output TaskParameter="AndroidArchitecture" PropertyName="NativeLibraryAbi" />
5858
<Output TaskParameter="HasMismatchedConfigurations" PropertyName="NativeHasMismatchedConfigurations" />

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Bindings.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ Copyright (C) 2012 Xamarin Inc. All rights reserved.
317317
Inputs="$(MSBuildProjectFullPath);$(_AndroidBuildPropertiesCache)"
318318
Outputs="$(_AndroidLibraryProjectImportsCache)">
319319
<ResolveLibraryProjectImports
320+
ContinueOnError="$(DesignTimeBuild)"
320321
CacheFile="$(_AndroidLibraryProjectImportsCache)"
321322
Assemblies="@(ReferencePath);@(ReferenceDependencyPaths)"
322323
ImportsDirectory="$(_LibraryProjectImportsDirectoryName)"

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,6 +1084,7 @@ because xbuild doesn't support framework reference assemblies.
10841084
Inputs="$(MSBuildProjectFullPath);@(ReferencePath);@(ReferenceDependencyPaths);$(_AndroidBuildPropertiesCache)"
10851085
Outputs="$(_AndroidLibraryProjectImportsCache)">
10861086
<ResolveLibraryProjectImports
1087+
ContinueOnError="$(DesignTimeBuild)"
10871088
CacheFile="$(_AndroidLibraryProjectImportsCache)"
10881089
Assemblies="@(ReferencePath);@(ReferenceDependencyPaths)"
10891090
ImportsDirectory="$(_LibraryProjectImportsDirectoryName)"
@@ -1336,6 +1337,7 @@ because xbuild doesn't support framework reference assemblies.
13361337

13371338
<!-- Parse primary R.java and create Resources.Designer.cs -->
13381339
<GenerateResourceDesigner
1340+
ContinueOnError="$(DesignTimeBuild)"
13391341
NetResgenOutputFile="$(ResgenTemporaryDirectory)\$(AndroidResgenFilename)"
13401342
JavaResgenInputFile="$(_GeneratedPrimaryJavaResgenFile)"
13411343
Namespace="$(AndroidResgenNamespace)"

0 commit comments

Comments
 (0)