Fix string constant options

Author: grendello

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrGenerator.cs

@@ -205,7 +205,10 @@ void WriteStrings (GeneratorWriteContext context)
 						WriteCommentLine (context, $" '{info.Value}'");
 					}
 
-					WriteGlobalVariableStart (context, info);
+					WriteGlobalVariableName (context, info);
+
+					// Strings must always be local symbols, global variables will point to them
+					WriteVariableOptions (context, LlvmIrVariableOptions.LocalString);
 					context.Output.Write ('[');
 					context.Output.Write (size.ToString (CultureInfo.InvariantCulture));
 					context.Output.Write ($" x {info.IrType}] ");
@@ -253,23 +256,37 @@ void WriteGlobalVariables (GeneratorWriteContext context)
 			}
 		}
 
-		void WriteGlobalVariableStart (GeneratorWriteContext context, LlvmIrGlobalVariable variable)
+		void WriteGlobalVariableName (GeneratorWriteContext context, LlvmIrGlobalVariable variable)
 		{
 			if (!String.IsNullOrEmpty (variable.Comment)) {
 				WriteCommentLine (context, variable.Comment);
 			}
 			context.Output.Write ('@');
 			context.Output.Write (variable.Name);
 			context.Output.Write (" = ");
+		}
 
-			LlvmIrVariableOptions options = variable.Options ?? LlvmIrGlobalVariable.DefaultOptions;
+		void WriteVariableOptions (GeneratorWriteContext context, LlvmIrVariableOptions options)
+		{
 			WriteLinkage (context, options.Linkage);
 			WritePreemptionSpecifier (context, options.RuntimePreemption);
 			WriteVisibility (context, options.Visibility);
 			WriteAddressSignificance (context, options.AddressSignificance);
 			WriteWritability (context, options.Writability);
 		}
 
+		void WriteVariableOptions (GeneratorWriteContext context, LlvmIrGlobalVariable variable, LlvmIrVariableOptions? defaultOptions = null)
+		{
+			LlvmIrVariableOptions options = variable.Options ?? defaultOptions ?? LlvmIrGlobalVariable.DefaultOptions;
+			WriteVariableOptions (context, options);
+		}
+
+		void WriteGlobalVariableStart (GeneratorWriteContext context, LlvmIrGlobalVariable variable)
+		{
+			WriteGlobalVariableName (context, variable);
+			WriteVariableOptions (context, variable, LlvmIrGlobalVariable.DefaultOptions);
+		}
+
 		void WriteGlobalVariable (GeneratorWriteContext context, LlvmIrGlobalVariable variable)
 		{
 			if (!context.InVariableGroup) {

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrModule.cs

@@ -272,7 +272,7 @@ public LlvmIrGlobalVariable AddGlobalVariable (Type type, string name, object? v
 			LlvmIrGlobalVariable ret;
 			if (type == typeof(string)) {
 				// The cast to `string?` is intentionally meant to throw if `value` type isn't a string.
-				ret = new LlvmIrStringVariable (name, new StringHolder ((string?)value)) {
+				ret = new LlvmIrStringVariable (name, new StringHolder ((string?)value), options) {
 					Comment = comment,
 				};
 				AddStringGlobalVariable ((LlvmIrStringVariable)ret);

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrVariable.cs

@@ -302,7 +302,7 @@ class LlvmIrStringVariable : LlvmIrGlobalVariable
 	public bool IsConstantStringLiteral { get; }
 
 	public LlvmIrStringVariable (string name, StringHolder value, LlvmIrVariableOptions? options = null)
-		: base (typeof(string), name, options ?? LlvmIrVariableOptions.GlobalConstexprString)
+		: base (typeof(string), name, options ?? LlvmIrVariableOptions.GlobalConstantStringPointer)
 	{
 		Value = value;
 		Encoding = value.Encoding;