[build] fail macOS build if tests fail #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://docs.microsoft.com/azure/devops/pipelines/tasks/test/publish-test-results#yaml-snippet Context: https://dev.azure.com/xamarin/public/_build/results?buildId=21614&view=ms.vss-test-web.build-test-results-tab Currently, if a test fails on macOS the build will still be green. We need to set `failTaskOnFailedTests` on the `PublishTestResults` step. I also filled out `testRunTitle`, to fix the display name shown on test results.
jonathanpeppers
force-pushed
the
azdo-macos-tests
branch
from
9a35925 to
0195935
Compare
Member
Author
|
The build here failed appropriately now: https://dev.azure.com/xamarin/public/_build/results?buildId=21660&view=ms.vss-test-web.build-test-results-tab |
pjcollins
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/azure/devops/pipelines/tasks/test/publish-test-results#yaml-snippet
Context: https://dev.azure.com/xamarin/public/_build/results?buildId=21614&view=ms.vss-test-web.build-test-results-tab
Currently, if a test fails on macOS the build will still be green.
We need to set
failTaskOnFailedTestson thePublishTestResultsstep.I also filled out
testRunTitle, to fix the display name shown ontest results.