JetBrains OpenJDK 11 detection #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenJDK from JetBrains does not have the `jre` directory which, so far, has been required by the `JdkInfo` class. Instead, there's just the `lib` directory which should be searched for the JVM libraries instead of `jre`. Modify `JdkInfo` so that it first checks the `jre` directory and, failing to find it, looks for the `lib` directory in the OpenJDK installation root. The changes make Xamarin.Android.Tools detect JetBrains OpenJDK 11 properly.
jonpryor
pushed a commit
that referenced
this pull request
Apr 22, 2020
Context: https://bintray.com/jetbrains/intellij-jdk/openjdk11-osx-x64 OpenJDK 11 from JetBrains does not have the `jre` directory which, so far, has been required by the `JdkInfo` class. Instead, there's just the `lib` directory which should be searched for the JVM libraries instead of `jre`. Modify `JdkInfo` so that it first checks the `jre` directory and, failing to find it, looks for the `lib` directory in the OpenJDK installation root. These changes allow Xamarin.Android.Tools tp detect JetBrains OpenJDK 11 properly.
jonpryor
pushed a commit
that referenced
this pull request
Feb 25, 2021
Changes: dotnet/android-libzipsharp@1.0.22...1.0.23 * dotnet/android-libzipsharp@521b54e Include Windows pdb in Nuget (#82) * dotnet/android-libzipsharp@9853933: [ci] Update packageSources in NuGet.config (#80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenJDK from JetBrains does not have the
jredirectory which, so far,has been required by the
JdkInfoclass. Instead, there's just thelibdirectory which should be searched for the JVM libraries insteadof
jre.Modify
JdkInfoso that it first checks thejredirectory and,failing to find it, looks for the
libdirectory in the OpenJDKinstallation root.
The changes make Xamarin.Android.Tools detect JetBrains OpenJDK 11
properly.