Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 4 additions & 34 deletions src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkUnix.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Linq;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
Expand Down Expand Up @@ -108,46 +109,15 @@ protected override IEnumerable<string> GetAllAvailableAndroidSdks ()

protected override string GetJavaSdkPath ()
{
var preferedJavaSdkPath = PreferedJavaSdkPath;
if (!string.IsNullOrEmpty (preferedJavaSdkPath))
return preferedJavaSdkPath;

// Look in PATH
foreach (var path in ProcessUtils.FindExecutablesInPath (JarSigner)) {
// Strip off "bin"
var dir = Path.GetDirectoryName (path);

if (ValidateJavaSdkLocation (dir))
return dir;
}

return null;
return JdkInfo.GetKnownSystemJdkInfos (Logger).FirstOrDefault ()?.HomePath;
}

public override bool ValidateJavaSdkLocation (string loc)
public override bool ValidateJavaSdkLocation (string loc)
{
var result = base.ValidateJavaSdkLocation (loc);

if (result) {
// handle apple's java stub
const string javaHomeExe = "/usr/libexec/java_home";

if (File.Exists (javaHomeExe)) {
// returns true if there is a java installed
var javaHomeTask = ProcessUtils.ExecuteToolAsync<bool> (javaHomeExe,
(output) => {
if (output.Contains ("(null)")) {
return false;
}

return true;
}, System.Threading.CancellationToken.None
);

if (!javaHomeTask.Result) {
return false;
}
}
return File.Exists (Path.Combine (loc, "bin", "javac"));
}

return result;
Expand Down