From 559af278e18e2994d9db4c52ff11de4829fc1b50 Mon Sep 17 00:00:00 2001 From: Dean Ellis Date: Tue, 6 Aug 2024 11:04:08 +0100 Subject: [PATCH] Be explicit about FileShare mode when using FileStream. We know that by default `FileShare` will be `Read` when using a `FileStream`. However lets be totally clear on what we want from this point on, so if there is a problem we know its not us. --- src/Microsoft.Android.Build.BaseTasks/Files.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Android.Build.BaseTasks/Files.cs b/src/Microsoft.Android.Build.BaseTasks/Files.cs index 75b0a3d2..9172847b 100644 --- a/src/Microsoft.Android.Build.BaseTasks/Files.cs +++ b/src/Microsoft.Android.Build.BaseTasks/Files.cs @@ -435,7 +435,7 @@ public static string HashFile (string filename) public static string HashFile (string filename, HashAlgorithm hashAlg) { - using (Stream file = new FileStream (filename, FileMode.Open, FileAccess.Read)) { + using (Stream file = new FileStream (filename, FileMode.Open, FileAccess.Read, FileShare.Read)) { byte[] hash = hashAlg.ComputeHash (file); return ToHexString (hash); } @@ -479,7 +479,7 @@ public static void DeleteFile (string filename, object log) public static bool IsPortablePdb (string filename) { try { - using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read)) { + using (var fs = new FileStream (filename, FileMode.Open, FileAccess.Read, FileShare.Read)) { using (var br = new BinaryReader (fs)) { return br.ReadUInt32 () == ppdb_signature; }