[Xamarin.Android.Tools.AndroidSdk] Eclipse Adoptium support #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/ Context: https://projects.eclipse.org/projects/adoptium AdoptOpenJDK has moved to the Eclipse foundation, and made two name changes in the process: 1. The project is now known as Eclipse Adoptium. 2. The macOS installation directory now matches the file glob `temurin-*.jdk`, not `adoptopenjdk-*.jdk`. 3. The Windows installation directory now installs into e.g. `%ProgramFiles%\Eclipse Foundation\jdk-*`. Rename `AdoptOpenJdkLocations.cs` to `EclipseAdoptiumJdkLocations.cs`, and check for *both* the "legacy" AdoptOpenJDK and new EclipseAdoptium paths.
jonpryor
force-pushed
the
jonp-elipse-adoptium-support
branch
from
c620c80 to
022f5d5
Compare
jonpryor
changed the title
mcumming
approved these changes
Aug 17, 2021
jonpryor
added a commit
that referenced
this pull request
Aug 20, 2021
Context: https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/ Context: https://projects.eclipse.org/projects/adoptium AdoptOpenJDK has moved to the Eclipse foundation, and made three name changes in the process: 1. The project is now known as Eclipse Adoptium. 2. The macOS installation directory now matches the file glob `temurin-*.jdk`, not `adoptopenjdk-*.jdk`. 3. The Windows installation directory now installs into e.g. `%ProgramFiles%\Eclipse Foundation\jdk-*`, not e.g. `%ProgramFiles%\AdoptOpenJDK\jdk-*`. Rename `AdoptOpenJdkLocations.cs` to `EclipseAdoptiumJdkLocations.cs`, and check for *both* the "legacy" AdoptOpenJDK and new Eclipse Adoptium paths.
jonpryor
added a commit
that referenced
this pull request
Aug 20, 2021
Context: https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/ Context: https://projects.eclipse.org/projects/adoptium AdoptOpenJDK has moved to the Eclipse foundation, and made three name changes in the process: 1. The project is now known as Eclipse Adoptium. 2. The macOS installation directory now matches the file glob `temurin-*.jdk`, not `adoptopenjdk-*.jdk`. 3. The Windows installation directory now installs into e.g. `%ProgramFiles%\Eclipse Foundation\jdk-*`, not e.g. `%ProgramFiles%\AdoptOpenJDK\jdk-*`. Rename `AdoptOpenJdkLocations.cs` to `EclipseAdoptiumJdkLocations.cs`, and check for *both* the "legacy" AdoptOpenJDK and new Eclipse Adoptium paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/
Context: https://projects.eclipse.org/projects/adoptium
AdoptOpenJDK has moved to the Eclipse foundation, and made two name
changes in the process:
temurin-*.jdk, notadoptopenjdk-*.jdk.%ProgramFiles%\Eclipse Foundation\jdk-*.Rename
AdoptOpenJdkLocations.cstoEclipseAdoptiumJdkLocations.cs,and check for both the "legacy" AdoptOpenJDK and new EclipseAdoptium
paths.