[build] Upgrade to NUnit 3.11.0 and NUnit.ConsoleRunner 3.9.0 (#66)

[Visual Studio 2019][0] requires an updated NUnit to load and run our
NUnit tests.

Update to NUnit 3.11.0, NUnit.ConsoleRunner 3.9.0, and
NUnit3TestAdapter 3.13.0 to appease Visual Studio.

Additionally, when trying to restore packages in the `monodroid` repo
within Visual Studio for Mac, we get:

	Error NU1105 Unable to find project information for 'Xamarin.Android.Tools.AndroidSdk.csproj'.
	The project file may be invalid or missing targets required for restore.

This is because this `$(TargetFrameworkVersion)` was set to `v4.5`
and the ones in monodroid are set to `v4.7.2` now.  We need to update
the `$(TargetFrameworkVersions)` values to v4.7.1 as well.

[0]: https://web.archive.org/web/20190307085042/https://visualstudio.microsoft.com/vs/preview

Author: dellis1972

Makefile

@@ -1,5 +1,5 @@
 CONFIGURATION   := Debug
-NUNIT_CONSOLE   := packages/NUnit.ConsoleRunner.3.2.1/tools/nunit3-console.exe
+NUNIT_CONSOLE   := packages/NUnit.ConsoleRunner.3.9.0/tools/nunit3-console.exe
 OS              := $(shell uname)
 RUNTIME         := mono --debug=casts
 V               ?= 0

azure-pipelines.yaml

@@ -16,7 +16,7 @@ jobs:
     displayName: 'VsTest - NUnit3'
     inputs:
       testAssemblyVer2: 'bin\TestDebug\*-Tests.dll'
-      pathtoCustomTestAdapters: 'packages\NUnit3TestAdapter.3.12.0\build\net35'
+      pathtoCustomTestAdapters: 'packages\NUnit3TestAdapter.3.13.0\build\net35'
   - powershell: |
       $hashOfLastVersionChange = & "git" "log" "--follow" "-1" "--pretty=%H" "nuget.version"
       $commitsSinceVersionChange = & "git" "rev-list" "--count" "$hashOfLastVersionChange..HEAD"
@@ -44,7 +44,7 @@ jobs:
     displayName: 'Build solution Xamarin.Android.Tools.sln'
     inputs:
       solution: Xamarin.Android.Tools.sln
-  - script: mono packages/NUnit.ConsoleRunner.3.2.1/tools/nunit3-console.exe bin/TestDebug/Xamarin.Android.Tools.AndroidSdk-Tests.dll
+  - script: mono packages/NUnit.ConsoleRunner.3.9.0/tools/nunit3-console.exe bin/TestDebug/Xamarin.Android.Tools.AndroidSdk-Tests.dll
     displayName: Run NUnit Tests
   - task: PublishTestResults@2
     condition: always()

src/Xamarin.Android.Tools.AndroidSdk/Tests/Xamarin.Android.Tools.AndroidSdk-Tests.csproj

@@ -1,5 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\..\..\packages\NUnit3TestAdapter.3.13.0\build\net35\NUnit3TestAdapter.props" Condition="Exists('..\..\..\packages\NUnit3TestAdapter.3.13.0\build\net35\NUnit3TestAdapter.props')" />
+  <Import Project="..\..\..\packages\NUnit.3.11.0\build\NUnit.props" Condition="Exists('..\..\..\packages\NUnit.3.11.0\build\NUnit.props')" />
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -9,7 +11,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>Xamarin.Android.Tools.Tests</RootNamespace>
     <AssemblyName>Xamarin.Android.Tools.AndroidSdk-Tests</AssemblyName>
-    <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.7.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -31,7 +33,7 @@
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="nunit.framework">
-      <HintPath>..\..\..\packages\NUnit.3.2.1\lib\net45\nunit.framework.dll</HintPath>
+      <HintPath>..\..\..\packages\NUnit.3.11.0\lib\net45\nunit.framework.dll</HintPath>
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core" />

src/Xamarin.Android.Tools.AndroidSdk/Tests/packages.config

@@ -1,9 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="NUnit" version="3.2.1" targetFramework="net45" />
-  <package id="NUnit.Console" version="3.2.1" />
-  <package id="NUnit.ConsoleRunner" version="3.2.1" />
-  <package id="NUnit.Extension.NUnitV2ResultWriter" version="3.2.1" />
-  <package id="NUnit3TestAdapter" version="3.12.0" targetFramework="net452" />
+  <package id="NUnit" version="3.11.0" targetFramework="net452" />
+  <package id="NUnit.Console" version="3.9.0" targetFramework="net452" />
+  <package id="NUnit.ConsoleRunner" version="3.9.0" targetFramework="net452" />
+  <package id="NUnit.Extension.NUnitProjectLoader" version="3.5.0" targetFramework="net452" />
+  <package id="NUnit.Extension.NUnitV2Driver" version="3.6.0" targetFramework="net452" />
+  <package id="NUnit.Extension.NUnitV2ResultWriter" version="3.5.0" targetFramework="net452" />
+  <package id="NUnit.Extension.TeamCityEventListener" version="1.0.3" targetFramework="net452" />
+  <package id="NUnit.Extension.VSProjectLoader" version="3.8.0" targetFramework="net452" />
+  <package id="NUnit3TestAdapter" version="3.13.0" targetFramework="net452" />
   <package id="Unofficial.Ionic.Zip" version="1.9.1.8" targetFramework="net45" />
 </packages>

src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj

@@ -7,7 +7,7 @@
     <OutputType>Library</OutputType>
     <RootNamespace>Xamarin.Android.Tools</RootNamespace>
     <AssemblyName>Xamarin.Android.Tools.AndroidSdk</AssemblyName>
-    <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.7.1</TargetFrameworkVersion>
     <ProductVersion>8.0.30703</ProductVersion>
     <SchemaVersion>2.0</SchemaVersion>
     <SignAssembly>true</SignAssembly>