Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented May 10, 2022

Updates CI to build with:

  • Classic: VS2022 17.2
  • .NET 6: Maui RC3

Types of reported API differences:

Fixed accuracy of unsigned Kotlin types due to dotnet/java-interop#946

(Previously needed Metadata.xml to fix this issue has been removed.)

Example:

#### Type Changed: Kotlin.UIntArray

Removed method:
public static bool Contains (int[] arg0, int element);

Added method:
public static bool Contains (int[] arg0, uint element);

Removed internal Kotlin methods from better metadata matching

Example:

#### Type Changed: Kotlin.Random.RandomKt

Removed method:

public static int TakeUpperBits (int obj, int bitCount);

Kotlin source

internal fun Int.takeUpperBits(bitCount: Int): Int =
    this.ushr(32 - bitCount) and (-bitCount).shr(31)

Better method parameter names from better Kotlin metadata matching

Example:

#### Type Changed: Kotlin.Sequences.SequenceScope

Modified methods:

-public abstract Java.Lang.Object Yield (Java.Lang.Object p0, Kotlin.Coroutines.IContinuation p1)
+public abstract Java.Lang.Object Yield (Java.Lang.Object value, Kotlin.Coroutines.IContinuation p1)
-public abstract Java.Lang.Object YieldAll (Java.Util.IIterator p0, Kotlin.Coroutines.IContinuation p1)
+public abstract Java.Lang.Object YieldAll (Java.Util.IIterator iterator, Kotlin.Coroutines.IContinuation p1)

New Metadata.xml

There seems to be a regression in the Kotlin metadata matching that resulted in 4 overloaded methods being incorrectly matched.

Example:

#### Type Changed: Kotlin.UIntArray

Removed methods:

public bool Contains (uint element);

Added methods:

public bool Contains (int element);

This has been filed as dotnet/java-interop#984. Metadata has been added in this PR to fix up the 4 cases.

@jpobst jpobst force-pushed the d17-2 branch 3 times, most recently from ee7d003 to cb053ba Compare May 12, 2022 19:14
@jpobst jpobst marked this pull request as ready for review May 12, 2022 21:02
@jpobst jpobst requested a review from moljac May 12, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants