-
Notifications
You must be signed in to change notification settings - Fork 64
Bind important missing compose stable packages #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind important missing compose stable packages #441
Conversation
|
Hey @moljac, could you please help to review and merge this PR? Thanks |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@moljac Did it fail? Could you please share the errors? Thanks |
|
|
@moljac Thanks for the help. |
not google maven repo https://repo1.maven.org/maven2/io/github/aakira/napier/1.4.1/ |
|
Thanks for helping to fix the issue. |
NP.
Partially. A lot of dependencies are exact/strict dependencies in form [1.0.1] and for new artifacts you skipped versions causing errors. Yes binderator does not report those and I am adding some logging info for the future use. (I work on new tooling, but have not enough time to continue). We'll need few rounds of updates for this one and I'll need your help after I untangle all mess. |
|
Thanks, do you prefer if I split this big PR into smaller ones? |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
error |
|
CI is still failing. |
config.json
Outdated
| { | ||
| "groupId": "com.google.guava", | ||
| "artifactId": "failureaccess", | ||
| "version": "1.0.1", | ||
| "nugetVersion": "1.0.1.5", | ||
| "nugetId": "Xamarin.Google.Guava.FailureAccess", | ||
| "dependencyOnly": true | ||
| }, | ||
| { | ||
| "groupId": "com.google.guava", | ||
| "artifactId": "guava", | ||
| "version": "29.0.0", | ||
| "nugetVersion": "29.0.0", | ||
| "nugetId": "Xamarin.Google.Guava", | ||
| "dependencyOnly": true | ||
| }, | ||
| { | ||
| "groupId": "com.google.guava", | ||
| "artifactId": "listenablefuture", | ||
| "version": "1.0", | ||
| "nugetVersion": "1.0.0.5", | ||
| "nugetId": "Xamarin.Google.Guava.ListenableFuture", | ||
| "dependencyOnly": true | ||
| }, | ||
| { | ||
| "groupId": "androidx.lifecycle", | ||
| "artifactId": "lifecycle-viewmodel-ktx", | ||
| "version": "2.3.0", | ||
| "nugetVersion": "2.3.1.3", | ||
| "nugetId": "Xamarin.AndroidX.Lifecycle.ViewModel.Ktx", | ||
| "dependencyOnly": true | ||
| }, | ||
| { | ||
| "groupId": "androidx.compose.ui", | ||
| "artifactId": "ui", | ||
| "version": "1.0.0", | ||
| "nugetVersion": "1.0.0", | ||
| "nugetId": "Xamarin.AndroidX.Compose.UI", | ||
| "dependencyOnly": true | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moljac all of those are duplicated in config.json.
Is this a bug?
First they are declare with dependencyOnly to false, and then to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those are duplicated, so I remove them here d99ef0a
|
ups neverending story hopefully last change |
|
OMG another round |
|
@moljac thank you so much for you effort in merging this PR, this is a very important step for the future of android development 👍 |
sorry for not being reviewed and merged earlier. There was tons of other stuff with higher priorities, then some blocking stuff, etc... BTW if you can create some samples and show me/us, so we can integrate those into tests - that would be great |
This PR depends on #436 and can only be merged after it.This PR is a continuation of #419
Support Libraries Version (eg: 23.3.0):
Compose bindings that are essential to bind native android libraries that use jetpack compose.
Does this change any of the generated binding API's?
No.
Describe your contribution
Those bindings are important to bind native android libraries that use jetpack compose, since they are very commonly used.
#352 introduced initial support for Jetpack Compse.
But there are some important missing packages.
For example, without
androidx.activity:activity-composeit's not possible to call compose from an Activity, hence, it's not possible to use compose at all.Without
androidx.compose.ui:ui-tooling*it's not possible to use one of the best features of compose that are previews.Without
com.google.android.material:compose-theme-adapterandcom.google.accompanist:accompanist-appcompat-themeit's not possible to reuse the existing theme from Views in the compose world.And there are more packages in the
com.google.accompanist:*, that are extensions to compose that make compose much more powerful and easy to use.