Skip to content

Commit 08a6f89

Browse files
authored
Merge pull request #432 from xamarin/core-parameternames
Use metadata from 1.6.0 to restore parameter names for AndroidX.Core.
2 parents cde54fa + e536263 commit 08a6f89

File tree

10 files changed

+3457
-121
lines changed

10 files changed

+3457
-121
lines changed

source/AndroidXProject.cshtml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@using System
1+
@using System
22
@using System.Linq
33
<Project Sdk="Xamarin.Legacy.Sdk">
44
<PropertyGroup>
@@ -71,25 +71,21 @@
7171
}
7272
</ItemGroup>
7373

74-
<ItemGroup>
74+
<ItemGroup>
7575
@foreach (var art in @Model.MavenArtifacts)
7676
{
77-
if (@Model.NuGetPackageId == "Xamarin.AndroidX.Core" )
78-
{
7977
<JavaSourceJar
8078
Include="..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-sources.jar"
81-
Condition="Exists('..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-sources.jar')"
79+
Condition="Exists('..\..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-sources.jar')"
8280
/>
83-
}
84-
<!--
8581
<JavaDocJar
8682
Include="..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-javadoc.jar"
87-
Condition="Exists('..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-javadoc.jar')"
83+
Condition="Exists('..\..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-javadoc.jar')"
8884
/>
89-
-->
9085
}
9186
</ItemGroup>
9287

88+
9389
<ItemGroup>
9490
@foreach (var art in @Model.MavenArtifacts) {
9591
<_AndroidDocumentationPath Include="..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-paramnames.txt" Condition="Exists('..\..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-paramnames.txt')" />
@@ -240,4 +236,4 @@
240236
</PropertyGroup>
241237
}
242238

243-
</Project>
239+
</Project>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
<metadata>
2+
<attr path="/api/package[@name='androidx.activity.contextaware']/interface[@name='OnContextAvailableListener']/method[@name='onContextAvailable' and count(parameter)=1 and parameter[1][@type='android.content.Context']]/parameter[1]" name="name">context</attr>
23
</metadata>

source/androidx.appcompat/appcompat/Additions/AndroidX.AppCompat.Widget.ActionBarOverlayLayout.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,12 @@ public virtual void OnNestedScrollAccepted(Android.Views.View child, Android.Vie
1313
return;
1414
}
1515

16-
public void OnNestedScrollAccepted(Android.Views.View child, Android.Views.View target, int axes)
17-
{
18-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
19-
20-
OnStartNestedScroll(child, target, scroll_axes);
21-
22-
return;
23-
}
24-
2516
public virtual bool OnStartNestedScroll(Android.Views.View child, Android.Views.View target, int axes, int @type)
2617
{
2718
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
2819

2920
return OnStartNestedScroll(child, target, scroll_axes, @type);
3021
}
31-
32-
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes)
33-
{
34-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
35-
36-
return OnStartNestedScroll(child, target, scroll_axes);
37-
}
3822
}
3923
}
4024

source/androidx.constraintlayout/constraintlayout/Additions/AndroidX.ConstraintLayout.Motion.Widget.MotionLayout.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,11 @@ public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Vi
1515
return;
1616
}
1717

18-
public void OnNestedScrollAccepted(Android.Views.View child, Android.Views.View target, int axes)
19-
{
20-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
21-
22-
OnStartNestedScroll(child, target, scroll_axes);
23-
24-
return;
25-
}
26-
2718
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes, int @type)
2819
{
2920
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
3021

3122
return OnStartNestedScroll (child, target, scroll_axes, @type);
3223
}
33-
34-
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes)
35-
{
36-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
37-
38-
return OnStartNestedScroll(child, target, scroll_axes);
39-
}
4024
}
4125
}

source/androidx.coordinatorlayout/coordinatorlayout/Additions/AndroidX.CoordinatorLayout.Widget.CoordinatorLayout.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,11 @@ public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Vi
1515
return;
1616
}
1717

18-
public void OnNestedScrollAccepted(Android.Views.View child, Android.Views.View target, int axes)
19-
{
20-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
21-
22-
OnStartNestedScroll(child, target, scroll_axes);
23-
24-
return;
25-
}
26-
2718
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes, int @type)
2819
{
2920
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
3021

3122
return OnStartNestedScroll (child, target, scroll_axes, @type);
3223
}
33-
34-
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes)
35-
{
36-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
37-
38-
return OnStartNestedScroll(child, target, scroll_axes);
39-
}
4024
}
4125
}

source/androidx.core/core/Additions/AndroidX.Core.Widget.NestedScrollView.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,13 @@ public override void OnNestedScrollAccepted(Android.Views.View child, Android.Vi
2222
return;
2323
}
2424

25-
public void OnNestedScrollAccepted(Android.Views.View child, Android.Views.View target, int axes)
26-
{
27-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
28-
29-
OnStartNestedScroll(child, target, scroll_axes);
30-
31-
return;
32-
}
33-
3425
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes, int @type)
3526
{
3627
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
3728

3829
return OnStartNestedScroll(child, target, scroll_axes, @type);
3930
}
4031

41-
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes)
42-
{
43-
Android.Views.ScrollAxis scroll_axes = (Android.Views.ScrollAxis) axes;
4432

45-
return OnStartNestedScroll(child, target, scroll_axes);
46-
}
4733
}
4834
}

source/androidx.core/core/Transforms/Metadata.ParameterNames.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,14 @@
108108
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScroll' and count(parameter)=6 and parameter[1][@type='android.view.View'] and parameter[2][@type='int'] and parameter[3][@type='int'] and parameter[4][@type='int'] and parameter[5][@type='int'] and parameter[6][@type='int']]/parameter[4]" name="managedName">dxUnconsumed</attr>
109109
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScroll' and count(parameter)=6 and parameter[1][@type='android.view.View'] and parameter[2][@type='int'] and parameter[3][@type='int'] and parameter[4][@type='int'] and parameter[5][@type='int'] and parameter[6][@type='int']]/parameter[5]" name="managedName">dyUnconsumed</attr>
110110
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScroll' and count(parameter)=6 and parameter[1][@type='android.view.View'] and parameter[2][@type='int'] and parameter[3][@type='int'] and parameter[4][@type='int'] and parameter[5][@type='int'] and parameter[6][@type='int']]/parameter[6]" name="managedName">@type</attr>
111-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[1]" name="name">child</attr>
112-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[2]" name="name">target</attr>
113-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[3]" name="name">axes</attr>
114-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[4]" name="name">@type</attr>
115-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[1]" name="name">child</attr>
116-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[2]" name="name">target</attr>
117-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[3]" name="name">axes</attr>
118-
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[4]" name="name">@type</attr>
111+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[1]" name="managedName">child</attr>
112+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[2]" name="managedName">target</attr>
113+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[3]" name="managedName">axes</attr>
114+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onNestedScrollAccepted' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[4]" name="managedName">@type</attr>
115+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[1]" name="managedName">child</attr>
116+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[2]" name="managedName">target</attr>
117+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[3]" name="managedName">axes</attr>
118+
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStartNestedScroll' and count(parameter)=4 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int'] and parameter[4][@type='int']]/parameter[4]" name="managedName">@type</attr>
119119
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStopNestedScroll' and count(parameter)=2 and parameter[1][@type='android.view.View'] and parameter[2][@type='int']]/parameter[1]" name="managedName">target</attr>
120120
<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent2']/method[@name='onStopNestedScroll' and count(parameter)=2 and parameter[1][@type='android.view.View'] and parameter[2][@type='int']]/parameter[2]" name="managedName">@type</attr>
121121
<attr path="/api/package[@name='androidx.core.view']/interface[@name='OnApplyWindowInsetsListener']/method[@name='onApplyWindowInsets' and count(parameter)=2 and parameter[1][@type='android.view.View'] and parameter[2][@type='androidx.core.view.WindowInsetsCompat']]/parameter[1]" name="managedName">v</attr>

0 commit comments

Comments
 (0)