Address PR comments and fix compiler error on unix since TdsParserSafeHandles only exist on windows

Author: lcheunglci

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

@@ -475,9 +475,6 @@
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\TdsParameterSetter.cs">
       <Link>Microsoft\Data\SqlClient\TdsParameterSetter.cs</Link>
     </Compile>
-    <Compile Include="..\..\src\Microsoft\Data\SqlClient\TdsParserSafeHandles.cs">
-      <Link>Microsoft\Data\SqlClient\TdsParserSafeHandles.cs</Link>
-    </Compile>
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\TdsRecordBufferSetter.cs">
       <Link>Microsoft\Data\SqlClient\TdsRecordBufferSetter.cs</Link>
     </Compile>
@@ -665,6 +662,9 @@
     <Compile Include="Microsoft\Data\SqlClient\SqlColumnEncryptionCertificateStoreProvider.Windows.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlColumnEncryptionCngProvider.Windows.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlColumnEncryptionCspProvider.Windows.cs" />
+    <Compile Include="..\..\src\Microsoft\Data\SqlClient\TdsParserSafeHandles.cs">
+      <Link>Microsoft\Data\SqlClient\TdsParserSafeHandles.cs</Link>
+    </Compile>
   </ItemGroup>
   <!-- Unix only -->
   <ItemGroup Condition="'$(TargetsUnix)' == 'true'">

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -517,7 +517,7 @@ internal void Connect(ServerInfo serverInfo,
             // Clean up IsSQLDNSCachingSupported flag from previous status
             _connHandler.IsSQLDNSCachingSupported = false;
 
-            UInt32 sniStatus = SNILoadHandle.SingletonInstance.SNIStatus;
+            UInt32 sniStatus = SNILoadHandle.SingletonInstance.Status;
             if (sniStatus != TdsEnums.SNI_SUCCESS)
             {
                 _physicalStateObj.AddError(ProcessSNIError(_physicalStateObj));

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserSafeHandles.cs

@@ -5,10 +5,10 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Threading;
 #if NETFRAMEWORK
-using System.Runtime.CompilerServices;
 using Microsoft.Data.Common;
 #endif
 
@@ -53,7 +53,7 @@ public bool ClientOSEncryptionSupport
                     {
                         try
                         {
-                            UInt32 value = 0;
+                            uint value = 0;
                             // Query OS to find out whether encryption is supported.
                             SNINativeMethodWrapper.SNIQueryInfo(SNINativeMethodWrapper.QTypes.SNI_QUERY_CLIENT_ENCRYPT_POSSIBLE, ref value);
                             _clientOSEncryptionSupport = value != 0;
@@ -85,12 +85,7 @@ override protected bool ReleaseHandle()
             return true;
         }
 
-#if NETFRAMEWORK
-// TODO: update references
-        public uint SNIStatus => _sniStatus;
-#else
         public uint Status => _sniStatus;
-#endif
 
         public EncryptionOptions Options => _encryptionOption;
 
@@ -161,17 +156,15 @@ internal SNIHandle(
             bool flushCache,
             bool fSync,
             bool fParallel,
-			#if NETFRAMEWORK
+#if NETFRAMEWORK
             TransparentNetworkResolutionState transparentNetworkResolutionState,
             int totalTimeout,
-			#endif
+#endif
             SqlConnectionIPAddressPreference ipPreference,
             SQLDNSInfo cachedDNSInfo)
             : base(IntPtr.Zero, true)
         {
-#if NETFRAMEWORK
             RuntimeHelpers.PrepareConstrainedRegions();
-#endif
             try
             { }
             finally