From c9f9ee72fe6f7672867c8ecd80107c03f5ffe6df Mon Sep 17 00:00:00 2001 From: Tim Date: Wed, 28 Feb 2024 19:13:21 -0500 Subject: [PATCH] Always fail if dotnet command failed. --- .../Toolchains/DotNetCli/DotNetCliCommandResult.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs b/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs index 3d65270621..4a5b00a1fd 100644 --- a/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs +++ b/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommandResult.cs @@ -35,7 +35,7 @@ public static DotNetCliCommandResult Failure(TimeSpan time, string standardError [PublicAPI] public BuildResult ToBuildResult(GenerateResult generateResult) - => IsSuccess || File.Exists(generateResult.ArtifactsPaths.ExecutablePath) // dotnet cli could have successfully built the program, but returned 1 as exit code because it had some warnings + => IsSuccess ? BuildResult.Success(generateResult) : BuildResult.Failure(generateResult, AllInformation); }