Skip to content

Commit a1ccda9

Browse files
committed
Make sure that plugins can be built
1 parent e9def49 commit a1ccda9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def BuildCPU() {
189189
# This step is not necessary, but here we include it, to ensure that DMLC_CORE_USE_CMAKE flag is correctly propagated
190190
# We want to make sure that we use the configured header build/dmlc/build_config.h instead of include/dmlc/build_config_default.h.
191191
# See discussion at https://github.com/dmlc/xgboost/issues/5510
192-
${dockerRun} ${container_type} ${docker_binary} tests/ci_build/build_via_cmake.sh
192+
${dockerRun} ${container_type} ${docker_binary} tests/ci_build/build_via_cmake.sh -DPLUGIN_LZ4=ON -DPLUGIN_DENSE_PARSER=ON
193193
${dockerRun} ${container_type} ${docker_binary} build/testxgboost
194194
"""
195195
// Sanitizer test

plugin/lz4/sparse_page_lz4_format.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ inline void CompressArray<DType>::Write(dmlc::Stream* fo) {
156156
}
157157

158158
template<typename StorageIndex>
159-
class SparsePageLZ4Format : public SparsePageFormat {
159+
class SparsePageLZ4Format : public SparsePageFormat<SparsePage> {
160160
public:
161161
explicit SparsePageLZ4Format(bool use_lz4_hc)
162162
: use_lz4_hc_(use_lz4_hc) {

tests/ci_build/Dockerfile.cpu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ SHELL ["/bin/bash", "-c"] # Use Bash as shell
77
# Install all basic requirements
88
RUN \
99
apt-get update && \
10-
apt-get install -y tar unzip wget git build-essential doxygen graphviz llvm libasan2 libidn11 && \
10+
apt-get install -y tar unzip wget git build-essential doxygen graphviz llvm libasan2 libidn11 liblz4-dev && \
1111
# CMake
1212
wget -nv -nc https://cmake.org/files/v3.13/cmake-3.13.0-Linux-x86_64.sh --no-check-certificate && \
1313
bash cmake-3.13.0-Linux-x86_64.sh --skip-license --prefix=/usr && \

0 commit comments

Comments
 (0)