Fixed some grammar and spelling mistakes in the docs. #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1497
💛 - Coveralls |
MattBlack85
approved these changes
Nov 12, 2020
Contributor
MattBlack85
left a comment
MattBlack85
left a comment
There was a problem hiding this comment.
thanks @PoDuck , care to add yourself to the AUTHORS file?
Contributor
Author
|
If it's not absolutely required, I would like to reserve that action for
when I submit something more meaningful. I understand it's nice to
recognize contributors to projects, and that every contribution counts, but
I am not looking for recognition for taking 10 minutes to fix a few
spelling and grammar errors.
If it is a requirement though, let me know, and I will update the pr
accordingly.
Thanks
…On Thu, Nov 12, 2020 at 4:54 AM Mattia Procopio ***@***.***> wrote:
***@***.**** approved this pull request.
thanks @PoDuck <https://github.com/PoDuck> , care to add yourself to the
AUTHORS file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#895 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATCFPTWFB2FTJAS2I32PDLSPOWHBANCNFSM4TQ5RFUQ>
.
|
Contributor
|
@PoDuck understood, is not a hard requirement but I do not discriminate between the different types of contribution, for me, personally a typo is still a valuable contribution. Will merge after the green light in this case |
auvipy
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of the Change
Fixed grammar and spelling mistakes
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS