Skip to content

Commit b9d1443

Browse files
author
Aristobulo Meneses
committed
Merge remote-tracking branch 'upstream/master'
2 parents 4ff64b8 + cb5b231 commit b9d1443

19 files changed

+33
-58
lines changed

.travis.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,10 @@ python:
55
sudo: false
66

77
env:
8-
- TOXENV=py27-django18
98
- TOXENV=py27-django110
109
- TOXENV=py27-django111
11-
- TOXENV=py34-django18
1210
- TOXENV=py34-django110
1311
- TOXENV=py34-django111
14-
- TOXENV=py35-django18
1512
- TOXENV=py35-django110
1613
- TOXENV=py35-django111
1714
- TOXENV=py35-djangomaster

README.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ Requirements
4848
------------
4949

5050
* Python 2.7, 3.4, 3.5, 3.6
51-
* Django 1.8, 1.10, 1.11
52-
* On Django 1.8: django-braces >= 1.11.0
51+
* Django 1.10, 1.11
5352

5453
Installation
5554
------------

docs/rest-framework/getting_started.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,13 @@ Here's our project's root `urls.py` module:
6262
class UserSerializer(serializers.ModelSerializer):
6363
class Meta:
6464
model = User
65+
fields = ("username", "email", "first_name", "last_name", )
6566
6667
6768
class GroupSerializer(serializers.ModelSerializer):
6869
class Meta:
6970
model = Group
71+
fields = ("name", )
7072
7173
7274
# ViewSets define the view behavior.

oauth2_provider/compat.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,6 @@
1616
except ImportError:
1717
from urllib.parse import urlencode, quote_plus, unquote_plus
1818

19-
# changed in Django 1.10 (broken in Django 2.0)
20-
try:
21-
from django.urls import reverse, reverse_lazy
22-
except ImportError:
23-
from django.core.urlresolvers import reverse, reverse_lazy
24-
25-
# Added in Django 1.9, required as long as 1.8 is supported
26-
try:
27-
from django.contrib.auth.mixins import LoginRequiredMixin
28-
except ImportError:
29-
from braces.views import LoginRequiredMixin
30-
3119
# bastb Django 1.10 has updated Middleware. This code imports the Mixin required to get old-style
3220
# middleware working again
3321
# More?

oauth2_provider/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@
66
from django.conf import settings
77
from django.core.exceptions import ImproperlyConfigured
88
from django.db import models, transaction
9+
from django.urls import reverse
910
from django.utils import timezone
1011
from django.utils.encoding import python_2_unicode_compatible
1112
from django.utils.translation import ugettext_lazy as _
1213

13-
from .compat import parse_qsl, reverse, urlparse
14+
from .compat import parse_qsl, urlparse
1415
from .generators import generate_client_id, generate_client_secret
1516
from .scopes import get_scopes_backend
1617
from .settings import oauth2_settings

oauth2_provider/views/application.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
from django.contrib.auth.mixins import LoginRequiredMixin
12
from django.forms.models import modelform_factory
3+
from django.urls import reverse_lazy
24
from django.views.generic import CreateView, DeleteView, DetailView, ListView, UpdateView
35

4-
from ..compat import LoginRequiredMixin, reverse_lazy
56
from ..models import get_application_model
67

78

oauth2_provider/views/base.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22

3+
from django.contrib.auth.mixins import LoginRequiredMixin
34
from django.http import HttpResponse
45
from django.utils import timezone
56
from django.utils.decorators import method_decorator
@@ -8,7 +9,6 @@
89
from django.views.generic import FormView, View
910

1011
from .mixins import OAuthLibMixin
11-
from ..compat import LoginRequiredMixin
1212
from ..exceptions import OAuthToolkitError
1313
from ..forms import AllowForm
1414
from ..http import HttpResponseUriRedirect
@@ -166,6 +166,7 @@ def get(self, request, *args, **kwargs):
166166
return self.error_response(error)
167167

168168

169+
@method_decorator(csrf_exempt, name="dispatch")
169170
class TokenView(OAuthLibMixin, View):
170171
"""
171172
Implements an endpoint to provide access tokens
@@ -179,11 +180,6 @@ class TokenView(OAuthLibMixin, View):
179180
validator_class = oauth2_settings.OAUTH2_VALIDATOR_CLASS
180181
oauthlib_backend_class = oauth2_settings.OAUTH2_BACKEND_CLASS
181182

182-
# XXX: Django 1.8 compat
183-
@method_decorator(csrf_exempt)
184-
def dispatch(self, *args, **kwargs):
185-
return super(TokenView, self).dispatch(*args, **kwargs)
186-
187183
@method_decorator(sensitive_post_parameters('password'))
188184
def post(self, request, *args, **kwargs):
189185
url, headers, body, status = self.create_token_response(request)
@@ -194,6 +190,7 @@ def post(self, request, *args, **kwargs):
194190
return response
195191

196192

193+
@method_decorator(csrf_exempt, name="dispatch")
197194
class RevokeTokenView(OAuthLibMixin, View):
198195
"""
199196
Implements an endpoint to revoke access or refresh tokens
@@ -202,10 +199,6 @@ class RevokeTokenView(OAuthLibMixin, View):
202199
validator_class = oauth2_settings.OAUTH2_VALIDATOR_CLASS
203200
oauthlib_backend_class = oauth2_settings.OAUTH2_BACKEND_CLASS
204201

205-
# XXX: Django 1.8 compat
206-
def dispatch(self, *args, **kwargs):
207-
return super(RevokeTokenView, self).dispatch(*args, **kwargs)
208-
209202
def post(self, request, *args, **kwargs):
210203
url, headers, body, status = self.create_revocation_response(request)
211204
response = HttpResponse(content=body or '', status=status)

oauth2_provider/views/token.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
from __future__ import absolute_import, unicode_literals
22

3+
from django.contrib.auth.mixins import LoginRequiredMixin
4+
from django.urls import reverse_lazy
35
from django.views.generic import DeleteView, ListView
46

5-
from ..compat import LoginRequiredMixin, reverse_lazy
67
from ..models import get_access_token_model
78

89

tests/test_application_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
from django.contrib.auth import get_user_model
44
from django.test import TestCase
5+
from django.urls import reverse
56

6-
from oauth2_provider.compat import reverse
77
from oauth2_provider.models import get_application_model
88
from oauth2_provider.settings import oauth2_settings
99
from oauth2_provider.views.application import ApplicationRegistration

tests/test_authorization_code.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66

77
from django.contrib.auth import get_user_model
88
from django.test import RequestFactory, TestCase
9+
from django.urls import reverse
910
from django.utils import timezone
1011

11-
from oauth2_provider.compat import parse_qs, reverse, urlencode, urlparse
12+
from oauth2_provider.compat import parse_qs, urlencode, urlparse
1213
from oauth2_provider.models import (
1314
get_access_token_model,
1415
get_application_model,

0 commit comments

Comments
 (0)