Moved meta logic into function. Moved name in Authors and some small fixes

Author: mast22

AUTHORS

@@ -23,6 +23,7 @@ Matt Layman <https://www.mattlayman.com>
 Michael Haselton <[email protected]>
 Mohammed Ali Zubair <[email protected]>
 Nathanael Gordon <[email protected]>
+Nick Kozhenin <[email protected]>
 Ola Tarkowska <[email protected]>
 Oliver Sauder <[email protected]>
 Raphael Cohen <[email protected]>
@@ -36,4 +37,3 @@ Tim Selman <[email protected]>
 Tom Glowka <[email protected]>
 Ulrich Schuster <[email protected]>
 Yaniv Peer <[email protected]>
-Nick Kozhenin <[email protected]>

example/models.py

@@ -1,7 +1,6 @@
 # -*- encoding: utf-8 -*-
 from __future__ import unicode_literals
 
-from datetime import datetime
 from django.contrib.contenttypes.fields import GenericForeignKey, GenericRelation
 from django.contrib.contenttypes.models import ContentType
 from django.db import models
@@ -131,9 +130,6 @@ def __str__(self):
     class Meta:
         ordering = ("id",)
 
-    def modified_days_ago(self):
-        return (datetime.now() - self.modified_at).days
-
 
 class ProjectType(BaseModel):
     name = models.CharField(max_length=50)

example/serializers.py

@@ -281,7 +281,7 @@ def get_first_entry(self, obj):
         return obj.entries.first()
 
     def get_initials(self, obj):
-        return " ".join([word[0] for word in [obj.name]])
+        return "".join([word[0] for word in obj.name.split(" ")])
 
 
 class AuthorListSerializer(AuthorSerializer):
@@ -304,7 +304,7 @@ class Meta:
 class CommentSerializer(serializers.ModelSerializer):
     # testing remapping of related name
     writer = relations.ResourceRelatedField(source="author", read_only=True)
-    modified_days_ago = serializers.IntegerField(read_only=True)
+    modified_days_ago = serializers.SerializerMethodField()
 
     included_serializers = {
         "entry": EntrySerializer,
@@ -321,6 +321,9 @@ class Meta:
         # fields = ('entry', 'body', 'author',)
         meta_fields = ("modified_days_ago",)
 
+    def get_modified_days_ago(self, obj):
+        return (datetime.now() - obj.modified_at).days
+
 
 class ProjectTypeSerializer(serializers.ModelSerializer):
     class Meta:

rest_framework_json_api/renderers.py

@@ -378,11 +378,9 @@ def extract_included(
                         included_cache[new_item["type"]][
                             new_item["id"]
                         ] = utils.format_field_names(new_item)
-                        meta = cls.extract_meta(field, serializer_resource)
-                        if meta:
-                            included_cache[new_item["type"]][new_item["id"]][
-                                "meta"
-                            ] = utils.format_field_names(meta)
+                        cls.add_meta_to_included(
+                            included_cache, field, serializer_resource, new_item
+                        )
                         cls.extract_included(
                             serializer_fields,
                             serializer_resource,
@@ -407,11 +405,9 @@ def extract_included(
                     included_cache[new_item["type"]][
                         new_item["id"]
                     ] = utils.format_field_names(new_item)
-                    meta = cls.extract_meta(field, serializer_data)
-                    if meta:
-                        included_cache[new_item["type"]][new_item["id"]][
-                            "meta"
-                        ] = utils.format_field_names(meta)
+                    cls.add_meta_to_included(
+                        included_cache, field, serializer_data, new_item
+                    )
                     cls.extract_included(
                         serializer_fields,
                         serializer_data,
@@ -420,6 +416,14 @@ def extract_included(
                         included_cache,
                     )
 
+    @classmethod
+    def add_meta_to_included(cls, included_cache, field, resource, new_item):
+        meta = cls.extract_meta(field, resource)
+        if meta:
+            included_cache[new_item["type"]][new_item["id"]][
+                "meta"
+            ] = utils.format_field_names(meta)
+
     @classmethod
     def extract_meta(cls, serializer, resource):
         """