Skip to content

Replace hidden="hidden" attribute with style="display: none;". #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace hidden="hidden" attribute with style="display: none;". #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions debug_toolbar/templates/debug_toolbar/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
<script src="{% static 'debug_toolbar/js/jquery_existing.js' %}"></script>
{% endif %}
<script src="{% static 'debug_toolbar/js/toolbar.js' %}"></script>
<div id="djDebug" hidden="hidden" dir="ltr"
<div id="djDebug" style="display: none;" dir="ltr"
data-store-id="{{ toolbar.store_id }}" data-render-panel-url="{% url 'djdt:render_panel' %}"
{{ toolbar.config.ROOT_TAG_EXTRA_ATTRS|safe }}>
<div hidden="hidden" id="djDebugToolbar">
<div style="display: none;" id="djDebugToolbar">
<ul id="djDebugPanelList">
{% if toolbar.panels %}
<li><a id="djHideToolBarButton" href="#" title="{% trans "Hide toolbar" %}">{% trans "Hide" %} &#187;</a></li>
Expand Down Expand Up @@ -43,7 +43,7 @@
{% endfor %}
</ul>
</div>
<div hidden="hidden" id="djDebugToolbarHandle">
<div style="display: none;" id="djDebugToolbarHandle">
<span title="{% trans "Show toolbar" %}" id="djShowToolBarButton">&#171;</span>
</div>
{% for panel in toolbar.panels %}
Expand Down
4 changes: 2 additions & 2 deletions debug_toolbar/templates/debug_toolbar/panels/templates.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h4>{% blocktrans count templates|length as template_count %}Template{% plural %
{% if template.context %}
<dd>
<div class="djTemplateShowContextDiv"><a class="djTemplateShowContext"><span class="toggleArrow">&#x25B6;</span> {% trans "Toggle context" %}</a></div>
<div class="djTemplateHideContextDiv" hidden="hidden"><code>{{ template.context }}</code></div>
<div class="djTemplateHideContextDiv" style="display: none;"><code>{{ template.context }}</code></div>
</dd>
{% endif %}
{% endfor %}
Expand All @@ -35,7 +35,7 @@ <h4>{% blocktrans count context_processors|length as context_processors_count %}
<dt><strong>{{ key|escape }}</strong></dt>
<dd>
<div class="djTemplateShowContextDiv"><a class="djTemplateShowContext"><span class="toggleArrow">&#x25B6;</span> {% trans "Toggle context" %}</a></div>
<div class="djTemplateHideContextDiv" hidden="hidden"><code>{{ value|escape }}</code></div>
<div class="djTemplateHideContextDiv" style="display: none;"><code>{{ value|escape }}</code></div>
</dd>
{% endfor %}
</dl>
Expand Down
2 changes: 1 addition & 1 deletion debug_toolbar/templates/debug_toolbar/panels/timer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h4>{% trans "Resource usage" %}</h4>
</table>

<!-- This hidden div is populated and displayed by code in toolbar.timer.js -->
<div id="djDebugBrowserTiming" hidden="hidden">
<div id="djDebugBrowserTiming" style="display: none;">
<h4>{% trans "Browser timing" %}</h4>
<table>
<colgroup>
Expand Down