From 92e2978ef18b3de872762e6d39f893ad6fc28a71 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Sat, 26 Sep 2020 14:16:33 -0700 Subject: [PATCH] Replace .map() with .forEach() in JavaScript The code is not mapping the data to a new array. It was being used for iteration only. Therefore, forEach() is the more appropriate function which does not build a new Array. --- debug_toolbar/static/debug_toolbar/js/toolbar.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debug_toolbar/static/debug_toolbar/js/toolbar.js b/debug_toolbar/static/debug_toolbar/js/toolbar.js index edc37646d..c1dec139d 100644 --- a/debug_toolbar/static/debug_toolbar/js/toolbar.js +++ b/debug_toolbar/static/debug_toolbar/js/toolbar.js @@ -147,7 +147,7 @@ const djdt = { ajax(ajax_data.url, ajax_data).then(function(data) { djDebug.setAttribute('data-store-id', newStoreId); - Object.keys(data).map(function (panelId) { + Object.keys(data).forEach(function (panelId) { if (djDebug.querySelector('#'+panelId)) { djDebug.querySelector('#'+panelId).outerHTML = data[panelId].content; djDebug.querySelector('#djdt-'+panelId).outerHTML = data[panelId].button; @@ -172,7 +172,7 @@ const djdt = { ajax(ajax_data.url, ajax_data).then(function(data) { if (data.requests.constructor === Array) { - data.requests.map(function(request) { + data.requests.forEach(function(request) { if (!container.querySelector('[data-store-id="'+request.id+'"]')) { container.innerHTML = request.content + container.innerHTML; }