Rename do_not_include_history to exclude_history

Author: tim-schilling

debug_toolbar/panels/history/forms.py

@@ -9,6 +9,4 @@ class HistoryStoreForm(forms.Form):
     """
 
     store_id = forms.CharField(widget=forms.HiddenInput())
-    do_not_include_history = forms.BooleanField(
-        widget=forms.HiddenInput(), required=False
-    )
+    exclude_history = forms.BooleanField(widget=forms.HiddenInput(), required=False)

debug_toolbar/panels/history/panel.py

@@ -92,7 +92,7 @@ def content(self):
             stores[id] = {
                 "toolbar": toolbar,
                 "form": HistoryStoreForm(
-                    initial={"store_id": id, "do_not_include_history": True}
+                    initial={"store_id": id, "exclude_history": True}
                 ),
             }
 
@@ -104,7 +104,7 @@ def content(self):
                 "refresh_form": HistoryStoreForm(
                     initial={
                         "store_id": self.toolbar.store_id,
-                        "do_not_include_history": True,
+                        "exclude_history": True,
                     }
                 ),
             },

debug_toolbar/panels/history/views.py

@@ -14,14 +14,14 @@ def history_sidebar(request):
     if form.is_valid():
         store_id = form.cleaned_data["store_id"]
         toolbar = DebugToolbar.fetch(store_id)
-        do_not_include_history = form.cleaned_data["do_not_include_history"]
+        exclude_history = form.cleaned_data["exclude_history"]
         context = {}
         if toolbar is None:
             # When the store_id has been popped already due to
             # RESULTS_CACHE_SIZE
             return JsonResponse(context)
         for panel in toolbar.panels:
-            if do_not_include_history and not panel.is_historical:
+            if exclude_history and not panel.is_historical:
                 continue
             panel_context = {"panel": panel}
             context[panel.panel_id] = {
@@ -57,7 +57,7 @@ def history_refresh(request):
                                 "form": HistoryStoreForm(
                                     initial={
                                         "store_id": id,
-                                        "do_not_include_history": True,
+                                        "exclude_history": True,
                                     }
                                 ),
                             },

tests/panels/test_history.py

@@ -93,7 +93,7 @@ def test_history_panel_integration_content(self):
         toolbar = list(DebugToolbar._store.values())[0]
         content = toolbar.get_panel_by_id("HistoryPanel").content
         self.assertIn("bar", content)
-        self.assertIn('name="do_not_include_history" value="True"', content)
+        self.assertIn('name="exclude_history" value="True"', content)
 
     def test_history_sidebar_invalid(self):
         response = self.client.get(reverse("djdt:history_sidebar"))
@@ -103,7 +103,7 @@ def test_history_sidebar(self):
         """Validate the history sidebar view."""
         self.client.get("/json_view/")
         store_id = list(DebugToolbar._store)[0]
-        data = {"store_id": store_id, "do_not_include_history": True}
+        data = {"store_id": store_id, "exclude_history": True}
         response = self.client.get(reverse("djdt:history_sidebar"), data=data)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(
@@ -133,7 +133,7 @@ def test_history_sidebar_expired_store_id(self):
         """Validate the history sidebar view."""
         self.client.get("/json_view/")
         store_id = list(DebugToolbar._store)[0]
-        data = {"store_id": store_id, "do_not_include_history": True}
+        data = {"store_id": store_id, "exclude_history": True}
         response = self.client.get(reverse("djdt:history_sidebar"), data=data)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(
@@ -143,14 +143,14 @@ def test_history_sidebar_expired_store_id(self):
         self.client.get("/json_view/")
 
         # Querying old store_id should return in empty response
-        data = {"store_id": store_id, "do_not_include_history": True}
+        data = {"store_id": store_id, "exclude_history": True}
         response = self.client.get(reverse("djdt:history_sidebar"), data=data)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.json(), {})
 
         # Querying with latest store_id
         latest_store_id = list(DebugToolbar._store)[0]
-        data = {"store_id": latest_store_id, "do_not_include_history": True}
+        data = {"store_id": latest_store_id, "exclude_history": True}
         response = self.client.get(reverse("djdt:history_sidebar"), data=data)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(