Remove unnecessary sorting in SignedDataForm

The signature does not depend on a canonical representation of the data,
so don't bother sorting it.  Tweak the data for the tests as a
consequence.  However, note that the tests are still deterministic since
as of version 3.7, Python guarantees dictionary order.

Author: living180

debug_toolbar/forms.py

@@ -47,7 +47,6 @@ def verified_data(self):
 
     @classmethod
     def sign(cls, data):
-        items = sorted(data.items(), key=lambda item: item[0])
         return signing.Signer(salt=cls.salt).sign(
-            json.dumps({key: force_str(value) for key, value in items})
+            json.dumps({key: force_str(value) for key, value in data.items()})
         )

tests/test_forms.py

@@ -5,10 +5,10 @@
 
 from debug_toolbar.forms import SignedDataForm
 
-SIGNATURE = "-WiogJKyy4E8Om00CrFSy0T6XHObwBa6Zb46u-vmeYE"
+SIGNATURE = "O7cv5oYzP3ZgjSBrJwdidTUQ5kBWI7oD1xn8fb2vK-w"
 
 DATA = {"value": "foo", "date": datetime(2020, 1, 1, tzinfo=timezone.utc)}
-SIGNED_DATA = f'{{"date": "2020-01-01 00:00:00+00:00", "value": "foo"}}:{SIGNATURE}'
+SIGNED_DATA = f'{{"value": "foo", "date": "2020-01-01 00:00:00+00:00"}}:{SIGNATURE}'
 
 
 class FooForm(forms.Form):