Optionally render js/css

gone · gone · commit 4068382ebb10 · 2021-12-28T19:39:59.000-05:00
diff --git a/debug_toolbar/templates/debug_toolbar/base.html b/debug_toolbar/templates/debug_toolbar/base.html
@@ -1,10 +1,14 @@
 {% load i18n static %}
 {% block css %}
-<link rel="stylesheet" href="{% static 'debug_toolbar/css/print.css' %}" media="print">
-<link rel="stylesheet" href="{% static 'debug_toolbar/css/toolbar.css' %}">
+  {% if toolbar.should_render_css %}
+    <link rel="stylesheet" href="{% static 'debug_toolbar/css/print.css' %}" media="print">
+    <link rel="stylesheet" href="{% static 'debug_toolbar/css/toolbar.css' %}">
+  {% endif %}
 {% endblock %}
 {% block js %}
-<script type="module" src="{% static 'debug_toolbar/js/toolbar.js' %}" async></script>
+  {% if toolbar.should_render_js %}
+    <script type="module" src="{% static 'debug_toolbar/js/toolbar.js' %}" async></script>
+  {% endif %}
 {% endblock %}
 <div id="djDebug" class="djdt-hidden" dir="ltr"
      {% if not toolbar.should_render_panels %}
diff --git a/debug_toolbar/toolbar.py b/debug_toolbar/toolbar.py
@@ -34,6 +34,7 @@ def __init__(self, request, get_response):
         self.stats = {}
         self.server_timing_stats = {}
         self.store_id = None
+        self.should_render_css = self.should_render_js = True
 
     # Manage panels
 
diff --git a/tests/test_integration.py b/tests/test_integration.py
@@ -105,6 +105,22 @@ def get_response(request):
         response = DebugToolbarMiddleware(get_response)(self.request)
         self.assertEqual(response.content, b"<html><body></body></html>")
 
+    def test_optional_js_css(self):
+        def get_response(request):
+            return regular_view(request, "tuturu")
+
+        class NoStaticMiddleware(DebugToolbarMiddleware):
+            def configure_toolbar(self, request, toolbar):
+                toolbar.should_render_js = toolbar.should_render_css = False
+
+        response = DebugToolbarMiddleware(get_response)(self.request)
+        self.assertContains(response, b"<link")
+        self.assertContains(response, b"<script")
+
+        response = NoStaticMiddleware(get_response)(self.request)
+        self.assertNotContains(response, b"<link")
+        self.assertNotContains(response, b"<script")
+
     def test_cache_page(self):
         # Clear the cache before testing the views. Other tests that use cached_view
         # may run earlier and cause fewer cache calls.
