Refs #1668: Fixed the unsortable session keys fallback (#1994)

* Refs #1668: Fixed the unsortable session keys fallback
* Disable the flake8-simplify ruleset

Author: matthiask

debug_toolbar/panels/request.py

@@ -64,5 +64,8 @@ def generate_stats(self, request, response):
                     (k, request.session.get(k)) for k in sorted(request.session.keys())
                 ]
             except TypeError:
-                session_list = [(k, request.session.get(k)) for k in request.session]
+                session_list = [
+                    (k, request.session.get(k))
+                    for k in request.session.keys()  # (it's not a dict)
+                ]
             self.record_stats({"session": {"list": session_list}})

docs/changes.rst

@@ -13,6 +13,8 @@ Pending
 * Add translations for Bulgarian and Korean.
 * Update translations for several languages.
 * Include new translatable strings for translation.
+* Fixed a crash which happened in the fallback case when session keys cannot be
+  sorted.
 
 4.4.6 (2024-07-10)
 ------------------

pyproject.toml

@@ -74,16 +74,14 @@ lint.extend-select = [
   "PGH",    # pygrep-hooks
   "PIE",    # flake8-pie
   "RUF100", # Unused noqa directive
-  "SIM",    # flake8-simplify
   "SLOT",   # flake8-slots
   "UP",     # pyupgrade
   "W",      # pycodestyle warnings
 ]
 lint.extend-ignore = [
-  "B905",   # Allow zip() without strict=
-  "E501",   # Ignore line length violations
-  "SIM108", # Use ternary operator instead of if-else-block
-  "UP031",  # It's not always wrong to use percent-formatting
+  "B905",  # Allow zip() without strict=
+  "E501",  # Ignore line length violations
+  "UP031", # It's not always wrong to use percent-formatting
 ]
 lint.per-file-ignores."*/migrat*/*" = [
   "N806", # Allow using PascalCase model names in migrations