From 6e4e95ef1ae11522964a69546b23a96747576623 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Wed, 23 Apr 2025 09:55:45 +0800 Subject: [PATCH] DEV: Skip core features specs on stable (#269) The shared example is not available in stable yet --- .../javascripts/discourse/routes/update-index.js | 11 ++++------- spec/system/admin_update_spec.rb | 4 +--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/admin/assets/javascripts/discourse/routes/update-index.js b/admin/assets/javascripts/discourse/routes/update-index.js index eeafadc..94eedc7 100644 --- a/admin/assets/javascripts/discourse/routes/update-index.js +++ b/admin/assets/javascripts/discourse/routes/update-index.js @@ -1,8 +1,10 @@ import Route from "@ember/routing/route"; export default class UpgradeIndex extends Route { - model() { - return this.modelFor("update"); + async model() { + const model = this.modelFor("update"); + await this.loadRepos(model); + return model; } async loadRepos(list) { @@ -10,9 +12,4 @@ export default class UpgradeIndex extends Route { await repo.findLatest(); } } - - setupController(controller, model) { - super.setupController(...arguments); - this.loadRepos(model); - } } diff --git a/spec/system/admin_update_spec.rb b/spec/system/admin_update_spec.rb index c977536..b3e365f 100644 --- a/spec/system/admin_update_spec.rb +++ b/spec/system/admin_update_spec.rb @@ -8,7 +8,7 @@ before { sign_in(admin) } - xit "displays the admin update page with the right repositories" do + it "displays the admin update page with the right respositories" do visit("/admin/update") expect(page).to have_css("h3", exact_text: I18n.t("js.admin.docker.update_title")) @@ -17,7 +17,5 @@ expect(page).to have_css( "tr.repo .d-admin-row__overview-about a[href='https://meta.discourse.org/t/12655']", ) - ensure - puts page.html if ENV["CI"] end end