[bugfix] Implement the connection pool fixes onto the blocking connection pool. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't need to drain and re-fill the pool, when the connection is returned to the pool. it'll be properly reaped. * Actually set the connection's pool generation when making it.
jdost
pushed a commit
that referenced
this pull request
Jun 24, 2019
Remove reason arg from client_unblock. Use boolean 'error' arg instead. xref: redis#1036 (review)
jdost
pushed a commit
that referenced
this pull request
Jun 24, 2019
pycodestyle fixes to connection.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generational support for the
BlockingConnectionPool, continuing the work in:redis#732